[PATCH 2/2] drm: Verify debug message arguments

2011-04-19 Thread Marcin Slusarz
On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote: > On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote: > > > @@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private > > > *dev_priv, > > > i915_lvds_downclock) { > > > dev_priv->lvds_downclock_avail = 1; > > >

Re: [PATCH 2/2] drm: Verify debug message arguments

2011-04-19 Thread Joe Perches
On Tue, 2011-04-19 at 18:26 +0200, Marcin Slusarz wrote: > On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote: > > On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote: > > > > - DRM_DEBUG_KMS("LVDS downclock is found in VBT. ", > > > > - "Norma

[PATCH 2/2] drm: Verify debug message arguments

2011-04-19 Thread Joe Perches
On Tue, 2011-04-19 at 18:26 +0200, Marcin Slusarz wrote: > On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote: > > On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote: > > > > - DRM_DEBUG_KMS("LVDS downclock is found in VBT. ", > > > > - "Norma

Re: [PATCH 2/2] drm: Verify debug message arguments

2011-04-19 Thread Marcin Slusarz
On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote: > On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote: > > > @@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private > > > *dev_priv, > > > i915_lvds_downclock) { > > > dev_priv->lvds_downclock_avail = 1; > > >

Re: [PATCH 2/2] drm: Verify debug message arguments

2011-04-18 Thread Joe Perches
On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote: > > @@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv, > > i915_lvds_downclock) { > > dev_priv->lvds_downclock_avail = 1; > > dev_priv->lvds_downclock = temp_downclock; > > - DR

[PATCH 2/2] drm: Verify debug message arguments

2011-04-18 Thread Joe Perches
On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote: > > @@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv, > > i915_lvds_downclock) { > > dev_priv->lvds_downclock_avail = 1; > > dev_priv->lvds_downclock = temp_downclock; > > - DR

Re: [PATCH 2/2] drm: Verify debug message arguments

2011-04-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/17/2011 08:35 PM, Joe Perches wrote: > Add __attribute__((format (printf, 4, 5))) to drm_ut_debug_printk > and fix fallout. > > Signed-off-by: Joe Perches Aside from the comment below about intel_bios.c, Reviewed-by: Ian Romanick especially

[PATCH 2/2] drm: Verify debug message arguments

2011-04-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/17/2011 08:35 PM, Joe Perches wrote: > Add __attribute__((format (printf, 4, 5))) to drm_ut_debug_printk > and fix fallout. > > Signed-off-by: Joe Perches Aside from the comment below about intel_bios.c, Reviewed-by: Ian Romanick especially

[PATCH 2/2] drm: Verify debug message arguments

2011-04-17 Thread Joe Perches
Add __attribute__((format (printf, 4, 5))) to drm_ut_debug_printk and fix fallout. Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_irq.c |9 + drivers/gpu/drm/i915/intel_bios.c |6 +++--- drivers/gpu/drm/i915/intel_display.c|8 drivers/gpu/

[PATCH 2/2] drm: Verify debug message arguments

2011-04-17 Thread Joe Perches
Add __attribute__((format (printf, 4, 5))) to drm_ut_debug_printk and fix fallout. Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_irq.c |9 + drivers/gpu/drm/i915/intel_bios.c |6 +++--- drivers/gpu/drm/i915/intel_display.c|8 drivers/gpu/