Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

2019-07-26 Thread David Zhang
On 2019-06-21 11:46 a.m., Daniel Vetter wrote: > On Fri, Jun 21, 2019 at 02:21:43PM +, Harry Wentland wrote: >> On 2019-06-05 1:06 p.m., Dingchen Zhang wrote: >>> to terminate the while-loop in drm_dp_aux_crc_work when >>> drm_dp_start/stop_crc >>> are called in the hook to set crc source. >

Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

2019-06-21 Thread Kazlauskas, Nicholas
On 6/21/19 11:46 AM, Daniel Vetter wrote: > On Fri, Jun 21, 2019 at 02:21:43PM +, Harry Wentland wrote: >> On 2019-06-05 1:06 p.m., Dingchen Zhang wrote: >>> to terminate the while-loop in drm_dp_aux_crc_work when >>> drm_dp_start/stop_crc >>> are called in the hook to set crc source. >>> >>>

Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

2019-06-21 Thread Daniel Vetter
On Fri, Jun 21, 2019 at 02:21:43PM +, Harry Wentland wrote: > On 2019-06-05 1:06 p.m., Dingchen Zhang wrote: > > to terminate the while-loop in drm_dp_aux_crc_work when > > drm_dp_start/stop_crc > > are called in the hook to set crc source. > > > > Cc:Leo Li , Harry , Nick > > > > Signed-of

Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

2019-06-21 Thread Harry Wentland
On 2019-06-05 1:06 p.m., Dingchen Zhang wrote: > to terminate the while-loop in drm_dp_aux_crc_work when drm_dp_start/stop_crc > are called in the hook to set crc source. > > Cc:Leo Li , Harry , Nick > > Signed-off-by: Dingchen Zhang I wonder how this isn't creating problems for Rockchip with

Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

2019-06-05 Thread Sam Ravnborg
Hi Dingchen I do not know this code, so please await feedback from others on the patch itself. On Wed, Jun 05, 2019 at 01:06:39PM -0400, Dingchen Zhang wrote: > to terminate the while-loop in drm_dp_aux_crc_work when drm_dp_start/stop_crc > are called in the hook to set crc source. > > Cc:Leo Li

[PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

2019-06-05 Thread Dingchen Zhang
to terminate the while-loop in drm_dp_aux_crc_work when drm_dp_start/stop_crc are called in the hook to set crc source. Cc:Leo Li , Harry , Nick Signed-off-by: Dingchen Zhang --- drivers/gpu/drm/drm_debugfs_crc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_de