[Intel-gfx] [PATCH 2/2] drm: Pass the user drm_mode_fb_cmd2 as const to .fb_create()

2015-11-17 Thread Jani Nikula
On Tue, 17 Nov 2015, John Harrison wrote: > This seems to have caused a warning to appear. I generally build with > -Werror which means my build is broken :(. > > intel_display.c: In function 'intel_user_framebuffer_create': > i915/intel_display.c(14593)2: warning: passing argument 2 of > 'intel

[Intel-gfx] [PATCH 2/2] drm: Pass the user drm_mode_fb_cmd2 as const to .fb_create()

2015-11-17 Thread John Harrison
This seems to have caused a warning to appear. I generally build with -Werror which means my build is broken :(. intel_display.c: In function 'intel_user_framebuffer_create': i915/intel_display.c(14593)2: warning: passing argument 2 of 'intel_framebuffer_create' discards 'const' qualifier from p

[Intel-gfx] [PATCH 2/2] drm: Pass the user drm_mode_fb_cmd2 as const to .fb_create()

2015-11-17 Thread Daniel Vetter
On Wed, Nov 11, 2015 at 07:11:29PM +0200, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > Drivers shouldn't clobber the passed in addfb ioctl parameters. > i915 was doing just that. To prevent it from happening again, > pass the struct around as const, starting all the way fr

[Intel-gfx] [PATCH 2/2] drm: Pass the user drm_mode_fb_cmd2 as const to .fb_create()

2015-11-16 Thread Tvrtko Ursulin
Hi, On 11/11/15 17:11, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > Drivers shouldn't clobber the passed in addfb ioctl parameters. > i915 was doing just that. To prevent it from happening again, > pass the struct around as const, starting all the way from > internal_frame

[PATCH 2/2] drm: Pass the user drm_mode_fb_cmd2 as const to .fb_create()

2015-11-11 Thread ville.syrj...@linux.intel.com
From: Ville Syrjälä Drivers shouldn't clobber the passed in addfb ioctl parameters. i915 was doing just that. To prevent it from happening again, pass the struct around as const, starting all the way from internal_framebuffer_create(). Signed-off-by: Ville Syrjälä --- I tried to cross-compi