Re: [PATCH 2/2] drm/vblank: Unexport drm_vblank_cleanup

2017-06-27 Thread Daniel Vetter
On Mon, Jun 26, 2017 at 06:19:49PM +0200, Daniel Vetter wrote: > There's no reason for drivers to call this, and all the ones I've > removed looked very fishy: > - Proper quiescenting of the vblank machinery should be done by > calling drm_crtc_vblank_off(), which is best done by shutting down >

[PATCH 2/2] drm/vblank: Unexport drm_vblank_cleanup

2017-06-26 Thread Daniel Vetter
There's no reason for drivers to call this, and all the ones I've removed looked very fishy: - Proper quiescenting of the vblank machinery should be done by calling drm_crtc_vblank_off(), which is best done by shutting down the entire display engine with drm_atomic_helper_shutdown. - Releasing