Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-05-11 Thread Clément Péron
On Sat, 9 May 2020 at 18:28, Clément Péron wrote: > > Hi Steven, > > On Thu, 7 May 2020 at 16:30, Steven Price wrote: > > > > On 02/05/2020 23:07, Clément Péron wrote: > > > Hi Steven, > > > > > > On Tue, 14 Apr 2020 at 15:10, Steven Price wrote: > > >> > > >> Hi Clément, > > >> > > >> On 13/04/

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-05-11 Thread Clément Péron
Hi Steven, On Thu, 7 May 2020 at 16:30, Steven Price wrote: > > On 02/05/2020 23:07, Clément Péron wrote: > > Hi Steven, > > > > On Tue, 14 Apr 2020 at 15:10, Steven Price wrote: > >> > >> Hi Clément, > >> > >> On 13/04/2020 18:28, Clément Péron wrote: > >>> Hi Steven, > >>> > > > > Since you'v

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-05-07 Thread Steven Price
On 02/05/2020 23:07, Clément Péron wrote: Hi Steven, On Tue, 14 Apr 2020 at 15:10, Steven Price wrote: Hi Clément, On 13/04/2020 18:28, Clément Péron wrote: Hi Steven, Getting a backtrace from the two occurrences, I see one added from: (debugfs_create_dir) from [] (create_regulat

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-05-03 Thread Clément Péron
Hi Steven, On Tue, 14 Apr 2020 at 15:10, Steven Price wrote: > > Hi Clément, > > On 13/04/2020 18:28, Clément Péron wrote: > > Hi Steven, > > > Getting a backtrace from the two occurrences, I see one added from: > >(debugfs_create_dir) from [] (create_regulator+0xe0/0x220) >(create_reg

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-16 Thread Mark Brown
On Tue, Apr 14, 2020 at 09:16:39PM +0200, Clément Péron wrote: > But if multiple regulator is not an issue and as each request is logic. > The first in device_init assure to enable the regulator and the second > in OPP assure the voltage level. > Maybe we can just fix this warning? Well, if you

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-15 Thread Clément Péron
Hi Liam and Mark, On Tue, 14 Apr 2020 at 15:10, Steven Price wrote: > > Hi Clément, > > On 13/04/2020 18:28, Clément Péron wrote: > > Hi Steven, > > > > On Mon, 13 Apr 2020 at 18:35, Clément Péron wrote: > >> > >> Hi Steven, > >> > >> On Mon, 13 Apr 2020 at 17:55, Steven Price wrote: > >>> > >>

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-15 Thread Clément Péron
Hi Mark, On Tue, 14 Apr 2020 at 20:55, Mark Brown wrote: > > On Tue, Apr 14, 2020 at 08:20:23PM +0200, Clément Péron wrote: > > Hi Liam and Mark, > > You might want to flag stuff like this in the subject line, I very > nearly deleted this without opening it since most of the email I get > about p

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-14 Thread Mark Brown
On Tue, Apr 14, 2020 at 08:20:23PM +0200, Clément Péron wrote: > Hi Liam and Mark, You might want to flag stuff like this in the subject line, I very nearly deleted this without opening it since most of the email I get about panfrost appears to be coming from me having sent patches rather than bei

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-14 Thread Steven Price
Hi Clément, On 13/04/2020 18:28, Clément Péron wrote: Hi Steven, On Mon, 13 Apr 2020 at 18:35, Clément Péron wrote: Hi Steven, On Mon, 13 Apr 2020 at 17:55, Steven Price wrote: On 13/04/2020 15:31, Clément Péron wrote: Hi, On Mon, 13 Apr 2020 at 16:18, Clément Péron wrote: Hi Steven

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-14 Thread Robin Murphy
On 2020-04-13 3:18 pm, Clément Péron wrote: Hi Steven, On Mon, 13 Apr 2020 at 15:18, Steven Price wrote: On 11/04/2020 21:06, Clément Péron wrote: OPP table can defined both frequency and voltage. Register the mali regulator if it exist. Signed-off-by: Clément Péron --- drivers/gpu/drm

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-14 Thread Clément Péron
Hi Steven, On Mon, 13 Apr 2020 at 17:55, Steven Price wrote: > > On 13/04/2020 15:31, Clément Péron wrote: > > Hi, > > > > On Mon, 13 Apr 2020 at 16:18, Clément Péron wrote: > >> > >> Hi Steven, > >> > >> On Mon, 13 Apr 2020 at 15:18, Steven Price wrote: > >>> > >>> On 11/04/2020 21:06, Clément

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-14 Thread Clément Péron
Hi Steven, On Mon, 13 Apr 2020 at 18:35, Clément Péron wrote: > > Hi Steven, > > On Mon, 13 Apr 2020 at 17:55, Steven Price wrote: > > > > On 13/04/2020 15:31, Clément Péron wrote: > > > Hi, > > > > > > On Mon, 13 Apr 2020 at 16:18, Clément Péron wrote: > > >> > > >> Hi Steven, > > >> > > >> On

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-14 Thread Clément Péron
Hi Steven, On Mon, 13 Apr 2020 at 15:18, Steven Price wrote: > > On 11/04/2020 21:06, Clément Péron wrote: > > OPP table can defined both frequency and voltage. > > > > Register the mali regulator if it exist. > > > > Signed-off-by: Clément Péron > > --- > > drivers/gpu/drm/panfrost/panfrost_d

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-14 Thread Clément Péron
Hi, On Mon, 13 Apr 2020 at 16:18, Clément Péron wrote: > > Hi Steven, > > On Mon, 13 Apr 2020 at 15:18, Steven Price wrote: > > > > On 11/04/2020 21:06, Clément Péron wrote: > > > OPP table can defined both frequency and voltage. > > > > > > Register the mali regulator if it exist. > > > > > > S

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-14 Thread Clément Péron
Hi Panfrost and OPP Maintainers, On Sat, 11 Apr 2020 at 22:06, Clément Péron wrote: > > OPP table can defined both frequency and voltage. > > Register the mali regulator if it exist. After this patch, Panfrost update properly both voltage and frequency. But the GPU is still not properly down-clo

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-13 Thread Steven Price
On 13/04/2020 15:31, Clément Péron wrote: Hi, On Mon, 13 Apr 2020 at 16:18, Clément Péron wrote: Hi Steven, On Mon, 13 Apr 2020 at 15:18, Steven Price wrote: On 11/04/2020 21:06, Clément Péron wrote: OPP table can defined both frequency and voltage. Register the mali regulator if it exi

Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-13 Thread Steven Price
On 11/04/2020 21:06, Clément Péron wrote: OPP table can defined both frequency and voltage. Register the mali regulator if it exist. Signed-off-by: Clément Péron --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 34 ++--- drivers/gpu/drm/panfrost/panfrost_device.h | 1 +

[PATCH 2/2] drm/panfrost: add devfreq regulator support

2020-04-13 Thread Clément Péron
OPP table can defined both frequency and voltage. Register the mali regulator if it exist. Signed-off-by: Clément Péron --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 34 ++--- drivers/gpu/drm/panfrost/panfrost_device.h | 1 + 2 files changed, 31 insertions(+), 4 deletions(