Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-05 Thread Neil Armstrong
Hi, On 04/01/2023 19:25, Rayyan Ansari wrote: Hello, I am not a maintainer, but I thought I might give a few comments. Any comment is always welcome ! On 03/01/2023 14:22, Neil Armstrong wrote: Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MT

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-04 Thread Rayyan Ansari
Hello, I am not a maintainer, but I thought I might give a few comments. On 03/01/2023 14:22, Neil Armstrong wrote: Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MTP board. By default the the panel is configured to work with DSI compressed streams

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-04 Thread Sam Ravnborg
Hi Neil, > > > > > > + > > > +struct visionox_vtdr6130 { > > > + struct drm_panel panel; > > > + struct mipi_dsi_device *dsi; > > > + struct gpio_desc *reset_gpio; > > > + struct regulator_bulk_data supplies[3]; > > > + bool prepared; > > > +}; > > > + > > > +static inline struct visionox_vtdr61

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-04 Thread Neil Armstrong
Hi Sam, On 03/01/2023 19:15, Sam Ravnborg wrote: Hi Neil, On Tue, Jan 03, 2023 at 03:22:28PM +0100, Neil Armstrong wrote: Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MTP board. By default the the panel is configured to work with DSI compressed

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-03 Thread Sam Ravnborg
Hi Neil, On Tue, Jan 03, 2023 at 03:22:28PM +0100, Neil Armstrong wrote: > Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel > found on the Qualcomm SM8550 MTP board. > > By default the the panel is configured to work with DSI compressed > streams, but can work in uncompressed vide

[PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-03 Thread Neil Armstrong
Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MTP board. By default the the panel is configured to work with DSI compressed streams, but can work in uncompressed video mode since 1080x2400 in RGB888 fits in the 4 DSI lanes bandwidth. While display c