Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-08 Thread Shawn Guo
On Sun, Aug 08, 2021 at 05:29:30PM +0200, Stephan Gerhold wrote: > > 2) The driver works good, if the kernel is launched via "fastboot boot". > >But if the kernel is flashed to eMMC and launched by bootloader with > >splash screen, kernel will fail to bring up the panel. After kernel > >

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-08 Thread Stephan Gerhold
On Sun, Aug 08, 2021 at 09:44:57PM +0800, Shawn Guo wrote: > On Wed, Aug 04, 2021 at 02:09:19PM +0200, Stephan Gerhold wrote: > > On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > > > + ... > > > + nt_dcs_write(0xb1, 0x6c, 0x21); > > > + nt_dcs_write(0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00);

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-08 Thread Shawn Guo
Hi Sam, On Wed, Aug 04, 2021 at 06:24:12PM +0200, Sam Ravnborg wrote: > Hi Shawn, > > see a few comments in the following. Thanks for the review comments! All of them will be addressed in v2. Shawn > On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > > It adds a drm driver for Truly

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-08 Thread Shawn Guo
Hi Stephan, Thanks for looking at the patch! On Wed, Aug 04, 2021 at 02:09:19PM +0200, Stephan Gerhold wrote: > Hi Shawn, > > Thanks for the patch! > > On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > > It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which > > can b

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-04 Thread Sam Ravnborg
Hi Shawn, see a few comments in the following. Sam On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which > can be found on Sony Xperia M4 Aqua phone. The panel backlight is > managed through DSI link. > > Sig

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-04 Thread Stephan Gerhold
Hi Shawn, Thanks for the patch! On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which > can be found on Sony Xperia M4 Aqua phone. The panel backlight is > managed through DSI link. > > Signed-off-by: Shawn Guo > ---

[PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-04 Thread Shawn Guo
It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which can be found on Sony Xperia M4 Aqua phone. The panel backlight is managed through DSI link. Signed-off-by: Shawn Guo --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1