Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-25 Thread Cai Huoqing
On 22 4月 22 01:01:14, Kari Argillander wrote: > This is just quick look up. I basically check some style issues and did > some basic static analyzing. > > I have run > - cppcheck (which found couple mistakes) > - flawfinder (did not found anything to my eyes) > - codespell (did find couple typo

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Kari Argillander
This is just quick look up. I basically check some style issues and did some basic static analyzing. I have run - cppcheck (which found couple mistakes) - flawfinder (did not found anything to my eyes) - codespell (did find couple typo) You can run these yourself also or check below. Couple

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Christian König
Am 21.04.22 um 11:13 schrieb Thomas Zimmermann: Hi Am 21.04.22 um 10:34 schrieb Christian König: Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Thomas Zimmermann
Hi Am 21.04.22 um 10:34 schrieb Christian König: Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are prefixed with dla_, others use nvdla_. It seems

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Thomas Zimmermann
Am 21.04.22 um 10:34 schrieb Christian König: Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are prefixed with dla_, others use nvdla_. It seems a

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Thomas Zimmermann
Hi Am 21.04.22 um 10:34 schrieb Christian König: Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are prefixed with dla_, others use nvdla_. It seems

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Christian König
Am 21.04.22 um 10:30 schrieb Thomas Zimmermann: (Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments:   * some functions are prefixed with dla_, others use nvdla_. It seems arbitrary to me. Please use nvdla_ consistently th

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-21 Thread Thomas Zimmermann
(Resending, as some MLs didn't like the size of the origninal mail.) Hi, thanks for your submission. Some general comments: * some functions are prefixed with dla_, others use nvdla_. It seems arbitrary to me. Please use nvdla_ consistently throughout the source code. * For reporting err

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-20 Thread kernel test robot
Hi Cai, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip linus/master v5.18-rc3 next-20220419] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-20 Thread kernel test robot
Hi Cai, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next drm-tip/drm-tip linus/master v5.18-rc3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-19 Thread Cai Huoqing
On 19 4月 22 16:07:44, Christian König wrote: > Am 19.04.22 um 15:59 schrieb Cai Huoqing: > > The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP > > which is integrated into NVIDIA Jetson AGX Xavier, > > so add driver support for this accelerator. > > > > Signed-off-by: Cai Huoqing

Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA

2022-04-19 Thread Christian König
Am 19.04.22 um 15:59 schrieb Cai Huoqing: The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP which is integrated into NVIDIA Jetson AGX Xavier, so add driver support for this accelerator. Signed-off-by: Cai Huoqing Well doesn't looks so bad on first glance (regarding coding st