Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2020-01-04 Thread Takashi Iwai
On Sat, 04 Jan 2020 00:01:14 +0100, Lyude Paul wrote: > > Got shown this patch at work and realized it still needed review, so I went > ahead and did that :) > > Reviewed-by: Lyude Paul Thanks! Let me know if the submission of the patch is needed. Takashi > > On Mon, 2019-07-22 at 16:38 +0

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2020-01-03 Thread Lyude Paul
Got shown this patch at work and realized it still needed review, so I went ahead and did that :) Reviewed-by: Lyude Paul On Mon, 2019-07-22 at 16:38 +0200, Takashi Iwai wrote: > This patch adds the support for the notification of HD-audio hotplug > via the already existing drm_audio_component f

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-08-27 Thread Takashi Iwai
On Mon, 22 Jul 2019 16:38:15 +0200, Takashi Iwai wrote: > > This patch adds the support for the notification of HD-audio hotplug > via the already existing drm_audio_component framework. This allows > us more reliable hotplug notification and ELD transfer without > accessing HD-audio bus; it's mo

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
On Mon, 22 Jul 2019 17:00:15 +0200, Ilia Mirkin wrote: > > On Mon, Jul 22, 2019 at 10:38 AM Takashi Iwai wrote: > > +static void > > +nv50_audio_component_init(struct nouveau_drm *drm) > > +{ > > + if (!component_add(drm->dev->dev, &nv50_audio_component_bind_ops)) > > + drm->a

Re: [PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Ilia Mirkin
On Mon, Jul 22, 2019 at 10:38 AM Takashi Iwai wrote: > +static void > +nv50_audio_component_init(struct nouveau_drm *drm) > +{ > + if (!component_add(drm->dev->dev, &nv50_audio_component_bind_ops)) > + drm->audio.component_registered = true; > +} Pardon my ignorance on this to

[PATCH 2/2] drm/nouveau: Add HD-audio component notifier support

2019-07-22 Thread Takashi Iwai
This patch adds the support for the notification of HD-audio hotplug via the already existing drm_audio_component framework. This allows us more reliable hotplug notification and ELD transfer without accessing HD-audio bus; it's more efficient, and more importantly, it works without waking up the