Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-11 Thread Thomas Zimmermann
Hi Am 11.09.19 um 17:21 schrieb Ville Syrjälä: > On Wed, Sep 11, 2019 at 05:08:45PM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 10.09.19 um 16:01 schrieb Ville Syrjälä: >>> On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: Support for vblank requires VSYNC to signal an int

Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-11 Thread Ville Syrjälä
On Wed, Sep 11, 2019 at 05:08:45PM +0200, Thomas Zimmermann wrote: > Hi > > Am 10.09.19 um 16:01 schrieb Ville Syrjälä: > > On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: > >> Support for vblank requires VSYNC to signal an interrupt, which is broken > >> on Matrox chipsets. > >

Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-11 Thread Thomas Zimmermann
Hi Am 10.09.19 um 16:01 schrieb Ville Syrjälä: > On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: >> Support for vblank requires VSYNC to signal an interrupt, which is broken >> on Matrox chipsets. > > I don't remember there being anything wrong with the vsync interrupt. > What

Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-10 Thread Ville Syrjälä
On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: > Support for vblank requires VSYNC to signal an interrupt, which is broken > on Matrox chipsets. The workaround that is used here and in other free > Matrox drivers is to program to the value of and > enable the VLINE interrupt.

Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-10 Thread Thomas Zimmermann
Hi thanks for the feedback. Am 10.09.19 um 16:01 schrieb Ville Syrjälä: > On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: >> Support for vblank requires VSYNC to signal an interrupt, which is broken >> on Matrox chipsets. > > I don't remember there being anything wrong with th

Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-10 Thread Ville Syrjälä
On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: > Support for vblank requires VSYNC to signal an interrupt, which is broken > on Matrox chipsets. I don't remember there being anything wrong with the vsync interrupt. What makes you think it's broken? > The workaround that is use

Re: [PATCH 2/2] drm/mgag200: Add vblank support

2019-09-10 Thread Gerd Hoffmann
On Mon, Sep 09, 2019 at 04:06:33PM +0200, Thomas Zimmermann wrote: > Support for vblank requires VSYNC to signal an interrupt, which is broken > on Matrox chipsets. The workaround that is used here and in other free > Matrox drivers is to program to the value of and > enable the VLINE interrupt.

[PATCH 2/2] drm/mgag200: Add vblank support

2019-09-09 Thread Thomas Zimmermann
Support for vblank requires VSYNC to signal an interrupt, which is broken on Matrox chipsets. The workaround that is used here and in other free Matrox drivers is to program to the value of and enable the VLINE interrupt. This triggers an interrupt at the same time when VSYNC begins. VLINE uses