Re: [PATCH 2/2] drm/mediatek: dpi/dsi: fix possible_crtcs calculation

2023-08-30 Thread Michael Walle
This won't work. On MT8195 there are two display IPs, vdosys0 and vdosys1, vdosys0 only has the main path while vdosys1 only has the external path. So you need to loop over each one in all_drm_private[j] to get the right crtc ID for MT8195. Ahh thanks, got it. -michael

Re: [PATCH 2/2] drm/mediatek: dpi/dsi: fix possible_crtcs calculation

2023-08-29 Thread NĂ­colas F . R . A . Prado
On Tue, Aug 29, 2023 at 03:19:41PM +0200, Michael Walle wrote: > mtk_drm_find_possible_crtc_by_comp() assumed that the main path will > always have the CRTC with id 0, the ext id 1 and the third id 2. This > is only true if the paths are all available. But paths are optional (see > also comment in

[PATCH 2/2] drm/mediatek: dpi/dsi: fix possible_crtcs calculation

2023-08-29 Thread Michael Walle
mtk_drm_find_possible_crtc_by_comp() assumed that the main path will always have the CRTC with id 0, the ext id 1 and the third id 2. This is only true if the paths are all available. But paths are optional (see also comment in mtk_drm_kms_init()), e.g. the main path might not be enabled or availab