Re: [PATCH 2/2] drm/mediatek: Apply CMDQ control flow

2019-11-19 Thread Hsin-Yi Wang
On Fri, Aug 30, 2019 at 7:41 AM Bibby Hsieh wrote: > @@ -405,26 +458,69 @@ void mtk_drm_crtc_cursor_update(struct drm_crtc *crtc, > struct drm_plane *plane, > return; > > mutex_lock(&priv->hw_lock); > - plane_helper_funcs->atomic_update(plane, plane_state); > -

Re: [PATCH 2/2] drm/mediatek: Apply CMDQ control flow

2019-09-23 Thread Pi-Hsun Shih
Hi Bibby, On Fri, Aug 30, 2019 at 3:41 PM Bibby Hsieh wrote: > ... > +static void ddp_cmdq_cb(struct cmdq_cb_data data) > +{ > + > +#if IS_ENABLED(CONFIG_MTK_CMDQ) > + struct mtk_cmdq_cb_data *cb_data = data.data; > + struct drm_crtc_state *crtc_state = cb_data->state; > + struc

Re: [PATCH 2/2] drm/mediatek: Apply CMDQ control flow

2019-08-30 Thread CK Hu
Hi, Bibby: On Fri, 2019-08-30 at 15:41 +0800, Bibby Hsieh wrote: > Unlike other SoCs, MT8183 does not have "shadow" > registers for performaing an atomic video mode > set or page flip at vblank/vsync. > > The CMDQ (Commend Queue) in MT8183 is used to help > update all relevant display controller

[PATCH 2/2] drm/mediatek: Apply CMDQ control flow

2019-08-30 Thread Bibby Hsieh
Unlike other SoCs, MT8183 does not have "shadow" registers for performaing an atomic video mode set or page flip at vblank/vsync. The CMDQ (Commend Queue) in MT8183 is used to help update all relevant display controller registers with critical time limation. Signed-off-by: YT Shen Signed-off-by: