Re: (subset) [PATCH 2/2] drm/imagination: Fix error path in pvr_vm_create_context

2023-12-15 Thread Maxime Ripard
On Wed, 13 Dec 2023 14:44:31 +, Donald Robson wrote: > It is possible to double free the vm_ctx->mmu_ctx object in this > function. > >     630 err_page_table_destroy: > --> 631 pvr_mmu_context_destroy(vm_ctx->mmu_ctx); > > The pvr_vm_context_put() function does: > > [...] Applied t

Re: [PATCH 2/2] drm/imagination: Fix error path in pvr_vm_create_context

2023-12-13 Thread Dan Carpenter
Thanks so much. Reviewed-by: Dan Carpenter regards, dan carpenter

[PATCH 2/2] drm/imagination: Fix error path in pvr_vm_create_context

2023-12-13 Thread Donald Robson
It is possible to double free the vm_ctx->mmu_ctx object in this function.     630 err_page_table_destroy: --> 631 pvr_mmu_context_destroy(vm_ctx->mmu_ctx); The pvr_vm_context_put() function does:     kref_put(&vm_ctx->ref_count, pvr_vm_context_release); Here the pvr_vm_context_rele