[Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-04 Thread Dave Airlie
> mode setting a tiny bit faster as well. > > I've got a couple more changes to work on today: > > ?1) re-train the monitor when it gets unplugged and then plugged back > ? ?in. Right now, if you kick the cable out, you're stuck fumbling > ? ?around in the dark trying to run 'xrandr' again. don't

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Jesse Barnes
"Dave Airlie" wrote: >> mode setting a tiny bit faster as well. >> >> I've got a couple more changes to work on today: >> >>  1) re-train the monitor when it gets unplugged and then plugged back >>    in. Right now, if you kick the cable out, you're stuck fumbling >>    around in the dark tryin

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Keith Packard
On Mon, 4 Oct 2010 06:33:01 +1000, Dave Airlie wrote: > don't you do this already? both radeon/nouveau handle DP replug fine, > I thought Intel would have been where I stole the code from. There was a one-line bug. Patch already posted. -- keith.pack...@intel.com pgpeOx3goDN8S.pgp Descriptio

[Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Keith Packard
On Mon, 4 Oct 2010 06:33:01 +1000, Dave Airlie wrote: > don't you do this already? both radeon/nouveau handle DP replug fine, > I thought Intel would have been where I stole the code from. There was a one-line bug. Patch already posted. -- keith.packard at intel.com -- next part --

[Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Jesse Barnes
"Dave Airlie" wrote: >> mode setting a tiny bit faster as well. >> >> I've got a couple more changes to work on today: >> >> ?1) re-train the monitor when it gets unplugged and then plugged back >> ? ?in. Right now, if you kick the cable out, you're stuck fumbling >> ? ?around in the dark tryin

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Dave Airlie
> mode setting a tiny bit faster as well. > > I've got a couple more changes to work on today: > >  1) re-train the monitor when it gets unplugged and then plugged back >    in. Right now, if you kick the cable out, you're stuck fumbling >    around in the dark trying to run 'xrandr' again. don't

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Jesse Barnes
"Keith Packard" wrote: >On Sun, 3 Oct 2010 08:10:48 -0700, Jesse Barnes >wrote: > >> Do these fixes help with the DP issues you've been seeing, Keith? >> Seems like the first one shouldn't change behavior since we ought to >> time out on waiting on vblank in that case, and the timeout is the

[Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Jesse Barnes
"Keith Packard" wrote: >On Sun, 3 Oct 2010 08:10:48 -0700, Jesse Barnes >wrote: > >> Do these fixes help with the DP issues you've been seeing, Keith? >> Seems like the first one shouldn't change behavior since we ought to >> time out on waiting on vblank in that case, and the timeout is the

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Keith Packard
On Sun, 3 Oct 2010 08:10:48 -0700, Jesse Barnes wrote: > Do these fixes help with the DP issues you've been seeing, Keith? > Seems like the first one shouldn't change behavior since we ought to > time out on waiting on vblank in that case, and the timeout is the same > as the msleep we used to u

[Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Keith Packard
On Sun, 3 Oct 2010 08:10:48 -0700, Jesse Barnes wrote: > Do these fixes help with the DP issues you've been seeing, Keith? > Seems like the first one shouldn't change behavior since we ought to > time out on waiting on vblank in that case, and the timeout is the same > as the msleep we used to u

[Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Chris Wilson
On Sun, 3 Oct 2010 00:33:06 -0700, Keith Packard wrote: > Instead of waiting for the display line value to settle, we can simply > wait for the pipe configuration register 'state' bit to turn off. Thanks Keith, series applied to -fixes. -Chris -- Chris Wilson, Intel Open Source Technology Cent

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Jesse Barnes
On Sun, 3 Oct 2010 00:33:06 -0700 Keith Packard wrote: > Instead of waiting for the display line value to settle, we can simply > wait for the pipe configuration register 'state' bit to turn off. > > Contrarywise, disabling the plane will not cause the display line > value to stop changing, so

[Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Jesse Barnes
On Sun, 3 Oct 2010 00:33:06 -0700 Keith Packard wrote: > Instead of waiting for the display line value to settle, we can simply > wait for the pipe configuration register 'state' bit to turn off. > > Contrarywise, disabling the plane will not cause the display line > value to stop changing, so

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Chris Wilson
On Sun, 3 Oct 2010 00:33:06 -0700, Keith Packard wrote: > Instead of waiting for the display line value to settle, we can simply > wait for the pipe configuration register 'state' bit to turn off. Thanks Keith, series applied to -fixes. -Chris -- Chris Wilson, Intel Open Source Technology Cent

[PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Keith Packard
Instead of waiting for the display line value to settle, we can simply wait for the pipe configuration register 'state' bit to turn off. Contrarywise, disabling the plane will not cause the display line value to stop changing, so instead we wait for the vblank interrupt bit to get set. And, we onl

[PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Keith Packard
Instead of waiting for the display line value to settle, we can simply wait for the pipe configuration register 'state' bit to turn off. Contrarywise, disabling the plane will not cause the display line value to stop changing, so instead we wait for the vblank interrupt bit to get set. And, we onl