Re: [PATCH 2/2] drm/gud: Use scatter-gather USB bulk transfer

2021-06-15 Thread Noralf Trønnes
Den 15.06.2021 11.17, skrev Peter Stuge: > Hi Noralf, > > Noralf Trønnes wrote: +static int gud_usb_bulk(struct gud_device *gdrm, size_t len) > .. + timer_setup_on_stack(&ctx.timer, gud_usb_bulk_timeout, 0); + mod_timer(&ctx.timer, jiffies + msecs_to_jiffies(3000)); >

Re: [PATCH 2/2] drm/gud: Use scatter-gather USB bulk transfer

2021-06-15 Thread Peter Stuge
Hi Noralf, Noralf Trønnes wrote: > >> +static int gud_usb_bulk(struct gud_device *gdrm, size_t len) .. > >> + timer_setup_on_stack(&ctx.timer, gud_usb_bulk_timeout, 0); > >> + mod_timer(&ctx.timer, jiffies + msecs_to_jiffies(3000)); > >> + > >> + usb_sg_wait(&ctx.sgr); > >> + > >

Re: [PATCH 2/2] drm/gud: Use scatter-gather USB bulk transfer

2021-06-15 Thread Noralf Trønnes
Den 14.06.2021 22.54, skrev Linus Walleij: > Hi Noralf, > > On Mon, Mar 29, 2021 at 8:01 PM Noralf Trønnes wrote: > >> There'a limit to how big a kmalloc buffer can be, and as memory gets >> fragmented it becomes more difficult to get big buffers. The downside of >> smaller buffers is that th

Re: [PATCH 2/2] drm/gud: Use scatter-gather USB bulk transfer

2021-06-14 Thread Linus Walleij
Hi Noralf, On Mon, Mar 29, 2021 at 8:01 PM Noralf Trønnes wrote: > There'a limit to how big a kmalloc buffer can be, and as memory gets > fragmented it becomes more difficult to get big buffers. The downside of > smaller buffers is that the driver has to split the transfer up which > hampers per

[PATCH 2/2] drm/gud: Use scatter-gather USB bulk transfer

2021-03-29 Thread Noralf Trønnes
There'a limit to how big a kmalloc buffer can be, and as memory gets fragmented it becomes more difficult to get big buffers. The downside of smaller buffers is that the driver has to split the transfer up which hampers performance. Compression might also take a hit because of the splitting. Solve