Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-18 Thread Rob Clark
On Wed, Jun 18, 2025 at 3:19 PM Danilo Krummrich wrote: > > On Wed, Jun 18, 2025 at 02:56:37PM -0700, Rob Clark wrote: > > On Wed, Jun 18, 2025 at 2:23 PM Danilo Krummrich wrote: > > > > > > On Tue, Jun 17, 2025 at 06:43:21AM -0700, Rob Clark wrote: > > > > On Tue, Jun 17, 2025 at 5:48 AM Rob Cla

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-18 Thread Danilo Krummrich
On Wed, Jun 18, 2025 at 02:56:37PM -0700, Rob Clark wrote: > On Wed, Jun 18, 2025 at 2:23 PM Danilo Krummrich wrote: > > > > On Tue, Jun 17, 2025 at 06:43:21AM -0700, Rob Clark wrote: > > > On Tue, Jun 17, 2025 at 5:48 AM Rob Clark > > > wrote: > > > > > > > > On Tue, Jun 17, 2025 at 2:51 AM Dan

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-18 Thread Danilo Krummrich
On Tue, Jun 17, 2025 at 06:43:21AM -0700, Rob Clark wrote: > On Tue, Jun 17, 2025 at 5:48 AM Rob Clark wrote: > > > > On Tue, Jun 17, 2025 at 2:51 AM Danilo Krummrich wrote: > > > > > > On Mon, Jun 16, 2025 at 03:25:08PM -0700, Rob Clark wrote: > > > > On Mon, Jun 16, 2025 at 2:39 PM Danilo Krumm

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-18 Thread Rob Clark
On Wed, Jun 18, 2025 at 2:23 PM Danilo Krummrich wrote: > > On Tue, Jun 17, 2025 at 06:43:21AM -0700, Rob Clark wrote: > > On Tue, Jun 17, 2025 at 5:48 AM Rob Clark > > wrote: > > > > > > On Tue, Jun 17, 2025 at 2:51 AM Danilo Krummrich wrote: > > > > > > > > On Mon, Jun 16, 2025 at 03:25:08PM

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-17 Thread Rob Clark
On Tue, Jun 17, 2025 at 5:48 AM Rob Clark wrote: > > On Tue, Jun 17, 2025 at 2:51 AM Danilo Krummrich wrote: > > > > On Mon, Jun 16, 2025 at 03:25:08PM -0700, Rob Clark wrote: > > > On Mon, Jun 16, 2025 at 2:39 PM Danilo Krummrich wrote: > > > > > > > > On Sat, Jun 14, 2025 at 08:03:20AM -0700,

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-17 Thread Rob Clark
On Tue, Jun 17, 2025 at 2:51 AM Danilo Krummrich wrote: > > On Mon, Jun 16, 2025 at 03:25:08PM -0700, Rob Clark wrote: > > On Mon, Jun 16, 2025 at 2:39 PM Danilo Krummrich wrote: > > > > > > On Sat, Jun 14, 2025 at 08:03:20AM -0700, Rob Clark wrote: > > > > On Sat, Jun 14, 2025 at 3:39 AM Danilo

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-17 Thread Danilo Krummrich
On Mon, Jun 16, 2025 at 03:25:08PM -0700, Rob Clark wrote: > On Mon, Jun 16, 2025 at 2:39 PM Danilo Krummrich wrote: > > > > On Sat, Jun 14, 2025 at 08:03:20AM -0700, Rob Clark wrote: > > > On Sat, Jun 14, 2025 at 3:39 AM Danilo Krummrich wrote: > > > > > > > > On Fri, Jun 13, 2025 at 04:57:03PM

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-16 Thread Rob Clark
On Mon, Jun 16, 2025 at 2:39 PM Danilo Krummrich wrote: > > On Sat, Jun 14, 2025 at 08:03:20AM -0700, Rob Clark wrote: > > On Sat, Jun 14, 2025 at 3:39 AM Danilo Krummrich wrote: > > > > > > On Fri, Jun 13, 2025 at 04:57:03PM -0700, Rob Clark wrote: > > > > For UNMAP/REMAP steps we could be needi

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-16 Thread Danilo Krummrich
On Sat, Jun 14, 2025 at 08:03:20AM -0700, Rob Clark wrote: > On Sat, Jun 14, 2025 at 3:39 AM Danilo Krummrich wrote: > > > > On Fri, Jun 13, 2025 at 04:57:03PM -0700, Rob Clark wrote: > > > For UNMAP/REMAP steps we could be needing to lock objects that are not > > > explicitly listed in the VM_BIN

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-14 Thread Rob Clark
On Sat, Jun 14, 2025 at 3:39 AM Danilo Krummrich wrote: > > On Fri, Jun 13, 2025 at 04:57:03PM -0700, Rob Clark wrote: > > For UNMAP/REMAP steps we could be needing to lock objects that are not > > explicitly listed in the VM_BIND ioctl in order to tear-down unmapped > > VAs. These helpers handle

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-14 Thread Danilo Krummrich
On Fri, Jun 13, 2025 at 04:57:03PM -0700, Rob Clark wrote: > For UNMAP/REMAP steps we could be needing to lock objects that are not > explicitly listed in the VM_BIND ioctl in order to tear-down unmapped > VAs. These helpers handle locking/preparing the needed objects. Yes, that's a common use-ca

Re: [PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-13 Thread Rob Clark
On Fri, Jun 13, 2025 at 4:57 PM Rob Clark wrote: > > For UNMAP/REMAP steps we could be needing to lock objects that are not > explicitly listed in the VM_BIND ioctl in order to tear-down unmapped > VAs. These helpers handle locking/preparing the needed objects. > > Note that these functions do no

[PATCH 2/2] drm/gpuvm: Add locking helpers

2025-06-13 Thread Rob Clark
For UNMAP/REMAP steps we could be needing to lock objects that are not explicitly listed in the VM_BIND ioctl in order to tear-down unmapped VAs. These helpers handle locking/preparing the needed objects. Note that these functions do not strictly require the VM changes to be applied before the ne