Re: [PATCH 2/2] drm/format: Split into more granular test cases

2022-09-09 Thread Maíra Canal
On 8/31/22 18:56, Michał Winiarski wrote: > While we have multiple test cases, most of them check multiple > conditions, calling the function that is tested multiple times with > different arguments (with comments that indicate test case boundary). > This usually means that it can be easily convert

Re: [PATCH 2/2] drm/format: Split into more granular test cases

2022-09-02 Thread Maíra Canal
On 9/2/22 11:06, Michał Winiarski wrote: On Wed, Aug 31, 2022 at 07:15:11PM -0300, Maíra Canal wrote: Hi Michał Some very minor nits inline, but either way: Reviewed-by: Maíra Canal On 8/31/22 18:56, Michał Winiarski wrote: While we have multiple test cases, most of them check multiple cond

Re: [PATCH 2/2] drm/format: Split into more granular test cases

2022-09-02 Thread Michał Winiarski
On Wed, Aug 31, 2022 at 07:15:11PM -0300, Maíra Canal wrote: > Hi Michał > > Some very minor nits inline, but either way: > > Reviewed-by: Maíra Canal > > On 8/31/22 18:56, Michał Winiarski wrote: > > While we have multiple test cases, most of them check multiple > > conditions, calling the fun

Re: [PATCH 2/2] drm/format: Split into more granular test cases

2022-08-31 Thread Maíra Canal
Hi Michał Some very minor nits inline, but either way: Reviewed-by: Maíra Canal On 8/31/22 18:56, Michał Winiarski wrote: While we have multiple test cases, most of them check multiple conditions, calling the function that is tested multiple times with different arguments (with comments that

[PATCH 2/2] drm/format: Split into more granular test cases

2022-08-31 Thread Michał Winiarski
While we have multiple test cases, most of them check multiple conditions, calling the function that is tested multiple times with different arguments (with comments that indicate test case boundary). This usually means that it can be easily converted into multiple test cases. Passing output: