Re: [PATCH 2/2] drm/fb-helper: Do not scale depth down to 0

2019-03-29 Thread Reza Arbab
On Thu, Mar 28, 2019 at 05:33:31PM +0100, Linus Walleij wrote: This makes perfect sense, but Dave Airlie already sent a similar patch some two weeks ago, I wonder what happened with it? Subject "avoid setting 0 depth". Argh, that he did! I'm not subscribed to dri-devel so I didn't see that. Di

Re: [PATCH 2/2] drm/fb-helper: Do not scale depth down to 0

2019-03-29 Thread Reza Arbab
On Thu, Mar 28, 2019 at 11:52:30AM -0500, Reza Arbab wrote: On Thu, Mar 28, 2019 at 05:33:31PM +0100, Linus Walleij wrote: This makes perfect sense, but Dave Airlie already sent a similar patch some two weeks ago, I wonder what happened with it? Subject "avoid setting 0 depth". Argh, that he d

Re: [PATCH 2/2] drm/fb-helper: Do not scale depth down to 0

2019-03-28 Thread Linus Walleij
On Fri, Mar 22, 2019 at 9:56 PM Reza Arbab wrote: > If the scaling loop in drm_fb_helper_single_fb_probe() only finds > supported depths greater than what it's looking for, it will set > sizes.surface_depth = 0. This broke my udl device: > > [drm] test CRTC 0 primary plane > udl 3-9.1:1.0: drm_fb

[PATCH 2/2] drm/fb-helper: Do not scale depth down to 0

2019-03-24 Thread Reza Arbab
If the scaling loop in drm_fb_helper_single_fb_probe() only finds supported depths greater than what it's looking for, it will set sizes.surface_depth = 0. This broke my udl device: [drm] test CRTC 0 primary plane udl 3-9.1:1.0: drm_fb_helper_single_fb_probe: test CRTC 0 format 0, depth=24 udl 3-9