Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-12 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 05:39:22PM +0300, Ville Syrjälä wrote: > On Thu, Apr 08, 2021 at 04:57:51PM +0300, Pekka Paalanen wrote: > > On Thu, 8 Apr 2021 13:30:16 +0200 > > Daniel Vetter wrote: > > > > > On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > > > > > > The point of these

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-09 Thread Pekka Paalanen
On Thu, 8 Apr 2021 17:39:22 +0300 Ville Syrjälä wrote: > On Thu, Apr 08, 2021 at 04:57:51PM +0300, Pekka Paalanen wrote: > > On Thu, 8 Apr 2021 13:30:16 +0200 > > Daniel Vetter wrote: > > > > > > Is it also so that passing MOD_INVALID to the explicit modifier uAPI > > > > (ADDFB2) is invalid

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-08 Thread Ville Syrjälä
On Thu, Apr 08, 2021 at 04:57:51PM +0300, Pekka Paalanen wrote: > On Thu, 8 Apr 2021 13:30:16 +0200 > Daniel Vetter wrote: > > > On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > > > > The point of these documentation patches is to establish the convention > > > that: > > > > >

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-08 Thread Pekka Paalanen
On Thu, 8 Apr 2021 13:30:16 +0200 Daniel Vetter wrote: > On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > > The point of these documentation patches is to establish the convention > > that: > > > > - drm_mode_get_plane::format_type_ptr is the list of pixel formats that > > ca

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-08 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > On Thu, 08 Apr 2021 08:39:10 + > Simon Ser wrote: > > > On Wednesday, April 7th, 2021 at 3:51 PM, Ville Syrjälä > > wrote: > > > > > > +* To find out the list of formats that support modifiers, > > > > userspace > >

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-08 Thread Pekka Paalanen
On Thu, 08 Apr 2021 08:39:10 + Simon Ser wrote: > On Wednesday, April 7th, 2021 at 3:51 PM, Ville Syrjälä > wrote: > > > > + * To find out the list of formats that support modifiers, userspace > > > + * must use the plane IN_FORMATS blob property. > > >*/ > > > > Addfb2+modifiers p

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-08 Thread Simon Ser
On Wednesday, April 7th, 2021 at 3:51 PM, Ville Syrjälä wrote: > > +* To find out the list of formats that support modifiers, userspace > > +* must use the plane IN_FORMATS blob property. > > */ > > Addfb2+modifiers predates the IN_FORMATS blob, so this doesn't > match reality. TBH

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-07 Thread Ville Syrjälä
On Tue, Apr 06, 2021 at 04:21:18PM -0300, Leandro Ribeiro wrote: > Emphasize how userspace should use the plane format list > (format_type_ptr) and the IN_FORMATS blob property. > > Formats exposed in the plane format list (format_type_ptr) do not > require modifiers, and formats that are present

[PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-06 Thread Leandro Ribeiro
Emphasize how userspace should use the plane format list (format_type_ptr) and the IN_FORMATS blob property. Formats exposed in the plane format list (format_type_ptr) do not require modifiers, and formats that are present in the IN_FORMATS blob property support modifiers. Note that these are not