Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-15 Thread Thomas Zimmermann
Hi Am 14.01.21 um 17:28 schrieb Kieran Bingham: Hi Thomas, On 14/01/2021 15:15, Thomas Zimmermann wrote: On 23/11/2020 11:56, Thomas Zimmermann wrote: The new GEM object function drm_gem_cma_mmap() sets the VMA flags and offset as in the old implementation and immediately maps in the buffer's

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 02:26:41PM +0100, Thomas Zimmermann wrote: > From d0583fe22cd0cd29749ff679e46e13b58de325cb Mon Sep 17 00:00:00 2001 > From: Thomas Zimmermann > Date: Thu, 14 Jan 2021 14:21:51 +0100 > Subject: [PATCH] drm/cma: Set vma ops in mmap function > > Signed-off-by: Thomas Zimmerma

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Kieran Bingham
Hi Thomas, On 14/01/2021 15:15, Thomas Zimmermann wrote: On 23/11/2020 11:56, Thomas Zimmermann wrote: > The new GEM object function drm_gem_cma_mmap() sets the VMA flags > and offset as in the old implementation and immediately maps in the > buffer's memory pages. > > Cha

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Thomas Zimmermann
Hi Am 14.01.21 um 15:34 schrieb Kieran Bingham: Hi Thomas, On 14/01/2021 13:26, Thomas Zimmermann wrote: Hi Kieran Am 14.01.21 um 13:51 schrieb Kieran Bingham: Hi Thomas, On 23/11/2020 11:56, Thomas Zimmermann wrote: The new GEM object function drm_gem_cma_mmap() sets the VMA flags and off

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Kieran Bingham
Hi Thomas, On 14/01/2021 13:26, Thomas Zimmermann wrote: > Hi Kieran > > Am 14.01.21 um 13:51 schrieb Kieran Bingham: >> Hi Thomas, >> >> On 23/11/2020 11:56, Thomas Zimmermann wrote: >>> The new GEM object function drm_gem_cma_mmap() sets the VMA flags >>> and offset as in the old implementation

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Thomas Zimmermann
Hi Kieran Am 14.01.21 um 13:51 schrieb Kieran Bingham: Hi Thomas, On 23/11/2020 11:56, Thomas Zimmermann wrote: The new GEM object function drm_gem_cma_mmap() sets the VMA flags and offset as in the old implementation and immediately maps in the buffer's memory pages. Changing CMA helpers to

Re: [PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2021-01-14 Thread Kieran Bingham
Hi Thomas, On 23/11/2020 11:56, Thomas Zimmermann wrote: > The new GEM object function drm_gem_cma_mmap() sets the VMA flags > and offset as in the old implementation and immediately maps in the > buffer's memory pages. > > Changing CMA helpers to use the GEM object function allows for the > remo

[PATCH 2/2] drm/cma-helper: Implement mmap as GEM CMA object functions

2020-11-23 Thread Thomas Zimmermann
The new GEM object function drm_gem_cma_mmap() sets the VMA flags and offset as in the old implementation and immediately maps in the buffer's memory pages. Changing CMA helpers to use the GEM object function allows for the removal of the special implementations for mmap and gem_prime_mmap callbac