[PATCH 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver

2016-07-11 Thread Archit Taneja
On 07/11/2016 02:14 PM, Philipp Zabel wrote: > Am Montag, den 11.07.2016, 14:02 +0530 schrieb Archit Taneja: > [...] > + /* PXL PLL setup */ > + if (tc->test_pattern) { I couldn't find out who is setting tc->test_pattern. Is it always 0? >>> >>> Hm, you are right. I wonder

[PATCH 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver

2016-07-11 Thread Archit Taneja
On 07/05/2016 01:30 PM, Philipp Zabel wrote: > Hi Archit, > > thanks for the review! > > Am Dienstag, den 05.07.2016, 10:08 +0530 schrieb Archit Taneja: > [...] >>> +#include >> >> This may not be needed. > > I'll check and remove it. > >>> +#ifndef regmap_read_poll_timeout >>> +#define regmap_r

[PATCH 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver

2016-07-11 Thread Philipp Zabel
Am Montag, den 11.07.2016, 14:02 +0530 schrieb Archit Taneja: [...] > >>> + /* PXL PLL setup */ > >>> + if (tc->test_pattern) { > >> > >> I couldn't find out who is setting tc->test_pattern. Is it always > >> 0? > > > > Hm, you are right. I wonder what a good mechanism would be to enable a > > test

[PATCH 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver

2016-07-05 Thread Archit Taneja
On 07/01/2016 08:20 PM, Philipp Zabel wrote: > From: Andrey Gusakov > > Add a drm_bridge driver for the Toshiba TC358767 DPI/DSI to > eDP/DP bridge. Currently only DPI input with 24-bit RGB is > supported. > > Signed-off-by: Andrey Gusakov > Signed-off-by: Philipp Zabel > --- > drivers/gpu/d

[PATCH 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver

2016-07-05 Thread Philipp Zabel
Hi Archit, thanks for the review! Am Dienstag, den 05.07.2016, 10:08 +0530 schrieb Archit Taneja: [...] > > +#include > > This may not be needed. I'll check and remove it. > > +#ifndef regmap_read_poll_timeout > > +#define regmap_read_poll_timeout(map, addr, val, cond, sleep_us, > > timeout_

[PATCH 2/2] drm/bridge: tc358767: Add DPI to eDP bridge driver

2016-07-01 Thread Philipp Zabel
From: Andrey Gusakov Add a drm_bridge driver for the Toshiba TC358767 DPI/DSI to eDP/DP bridge. Currently only DPI input with 24-bit RGB is supported. Signed-off-by: Andrey Gusakov Signed-off-by: Philipp Zabel --- drivers/gpu/drm/bridge/Kconfig|8 + drivers/gpu/drm/bridge/Makefile |