Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

2018-12-03 Thread Sam Bobroff
On Fri, Nov 30, 2018 at 10:41:08AM +0100, Daniel Vetter wrote: > On Fri, Nov 30, 2018 at 11:17:51AM +1100, Sam Bobroff wrote: > > On Thu, Nov 29, 2018 at 09:56:53AM +0100, Daniel Vetter wrote: > > > On Thu, Nov 29, 2018 at 9:05 AM Sam Bobroff > > > wrote: > > > > > > > > On Thu, Nov 29, 2018 at 0

Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

2018-11-30 Thread Daniel Vetter
On Fri, Nov 30, 2018 at 11:17:51AM +1100, Sam Bobroff wrote: > On Thu, Nov 29, 2018 at 09:56:53AM +0100, Daniel Vetter wrote: > > On Thu, Nov 29, 2018 at 9:05 AM Sam Bobroff wrote: > > > > > > On Thu, Nov 29, 2018 at 09:40:53AM +1000, Dave Airlie wrote: > > > > On Mon, 5 Nov 2018 at 15:59, Sam Bob

Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

2018-11-30 Thread Sam Bobroff
On Thu, Nov 29, 2018 at 09:56:53AM +0100, Daniel Vetter wrote: > On Thu, Nov 29, 2018 at 9:05 AM Sam Bobroff wrote: > > > > On Thu, Nov 29, 2018 at 09:40:53AM +1000, Dave Airlie wrote: > > > On Mon, 5 Nov 2018 at 15:59, Sam Bobroff wrote: > > > > > > > > When unloading the ast driver, a warning m

Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

2018-11-29 Thread Daniel Vetter
On Thu, Nov 29, 2018 at 9:05 AM Sam Bobroff wrote: > > On Thu, Nov 29, 2018 at 09:40:53AM +1000, Dave Airlie wrote: > > On Mon, 5 Nov 2018 at 15:59, Sam Bobroff wrote: > > > > > > When unloading the ast driver, a warning message is printed by > > > drm_mode_config_cleanup() because a reference is

Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

2018-11-29 Thread Sam Bobroff
On Thu, Nov 29, 2018 at 09:40:53AM +1000, Dave Airlie wrote: > On Mon, 5 Nov 2018 at 15:59, Sam Bobroff wrote: > > > > When unloading the ast driver, a warning message is printed by > > drm_mode_config_cleanup() because a reference is still held to one of > > the drm_connector structs. > > > > Cor

Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

2018-11-28 Thread Dave Airlie
On Mon, 5 Nov 2018 at 15:59, Sam Bobroff wrote: > > When unloading the ast driver, a warning message is printed by > drm_mode_config_cleanup() because a reference is still held to one of > the drm_connector structs. > > Correct this by calling drm_framebuffer_remove() in > ast_fbdev_destroy(). > >

[PATCH 2/2] drm/ast: Fix connector leak during driver unload

2018-11-05 Thread Sam Bobroff
When unloading the ast driver, a warning message is printed by drm_mode_config_cleanup() because a reference is still held to one of the drm_connector structs. Correct this by calling drm_framebuffer_remove() in ast_fbdev_destroy(). Signed-off-by: Sam Bobroff --- drivers/gpu/drm/ast/ast_fb.c |