Re: [PATCH 2/2] Use char * for struct drm_dp_aux_msg's buffer

2018-05-24 Thread Daniel Vetter
On Wed, May 23, 2018 at 12:56:25PM +0300, Jani Nikula wrote: > On Wed, 23 May 2018, Daniel Vetter wrote: > > On Tue, May 22, 2018 at 11:33:35AM +0300, Jani Nikula wrote: > >> On Mon, 21 May 2018, Maya Rashish wrote: > >> > In drm_dp_i2c_drain_msg we do msg.buffer += err which isn't > >> > legal f

Re: [PATCH 2/2] Use char * for struct drm_dp_aux_msg's buffer

2018-05-24 Thread coypu
It's GCC's -Wpointer-arith. I'm stealing your code for another project that happened to have it on by default. I'm trying to look for opportunities to contribute back positive changes :-) On Wed, May 23, 2018 at 11:09:28AM +0200, Daniel Vetter wrote: > On Tue, May 22, 2018 at 11:33:35AM +0300, Ja

Re: [PATCH 2/2] Use char * for struct drm_dp_aux_msg's buffer

2018-05-23 Thread Jani Nikula
On Wed, 23 May 2018, Daniel Vetter wrote: > On Tue, May 22, 2018 at 11:33:35AM +0300, Jani Nikula wrote: >> On Mon, 21 May 2018, Maya Rashish wrote: >> > In drm_dp_i2c_drain_msg we do msg.buffer += err which isn't >> > legal for void *. >> >> Well, this isn't pedantic C, it's GCC. There are tons

Re: [PATCH 2/2] Use char * for struct drm_dp_aux_msg's buffer

2018-05-23 Thread Daniel Vetter
On Tue, May 22, 2018 at 11:33:35AM +0300, Jani Nikula wrote: > On Mon, 21 May 2018, Maya Rashish wrote: > > In drm_dp_i2c_drain_msg we do msg.buffer += err which isn't > > legal for void *. > > Well, this isn't pedantic C, it's GCC. There are tons of pointer > arithmetics for void pointers all ov

Re: [PATCH 2/2] Use char * for struct drm_dp_aux_msg's buffer

2018-05-22 Thread Jani Nikula
On Mon, 21 May 2018, Maya Rashish wrote: > In drm_dp_i2c_drain_msg we do msg.buffer += err which isn't > legal for void *. Well, this isn't pedantic C, it's GCC. There are tons of pointer arithmetics for void pointers all over the kernel. BR, Jani. > --- > include/drm/drm_dp_helper.h | 2 +- >

[PATCH 2/2] Use char * for struct drm_dp_aux_msg's buffer

2018-05-21 Thread Maya Rashish
In drm_dp_i2c_drain_msg we do msg.buffer += err which isn't legal for void *. --- include/drm/drm_dp_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 62903bae..06f9a61f 100644 --- a/include/drm/drm_dp_helpe