Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-13 Thread Daniel Vetter
On Tue, Apr 13, 2021 at 11:29 AM Matthew Auld wrote: > > On Mon, 12 Apr 2021 at 18:01, Daniel Vetter wrote: > > > > On Mon, Apr 12, 2021 at 6:08 PM Matthew Auld > > wrote: > > > > > > On Mon, 12 Apr 2021 at 16:17, Daniel Vetter wrote: > > > > > > > > On Mon, Apr 12, 2021 at 10:05:25AM +0100, Ma

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-13 Thread Matthew Auld
On Mon, 12 Apr 2021 at 18:01, Daniel Vetter wrote: > > On Mon, Apr 12, 2021 at 6:08 PM Matthew Auld > wrote: > > > > On Mon, 12 Apr 2021 at 16:17, Daniel Vetter wrote: > > > > > > On Mon, Apr 12, 2021 at 10:05:25AM +0100, Matthew Auld wrote: > > > > We need to general our accessor for the page d

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 6:08 PM Matthew Auld wrote: > > On Mon, 12 Apr 2021 at 16:17, Daniel Vetter wrote: > > > > On Mon, Apr 12, 2021 at 10:05:25AM +0100, Matthew Auld wrote: > > > We need to general our accessor for the page directories and tables from > > > using the simple kmap_atomic to sup

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 07:01:19PM +0300, Jani Nikula wrote: > On Mon, 12 Apr 2021, Daniel Vetter wrote: > > And that's some serious wtf. Yes we've done some compile-time type > > casting automagic between i915_priv and dev in the past, and I think even > > that was bad taste. But it was justified

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Matthew Auld
On Mon, 12 Apr 2021 at 16:17, Daniel Vetter wrote: > > On Mon, Apr 12, 2021 at 10:05:25AM +0100, Matthew Auld wrote: > > We need to general our accessor for the page directories and tables from > > using the simple kmap_atomic to support local memory, and this setup > > must be done on acquisition

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Jani Nikula
On Mon, 12 Apr 2021, Daniel Vetter wrote: > And that's some serious wtf. Yes we've done some compile-time type > casting automagic between i915_priv and dev in the past, and I think even > that was bad taste. But it was justified with that we have these > everywhere (especially in the mmio macros)

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 10:05:25AM +0100, Matthew Auld wrote: > We need to general our accessor for the page directories and tables from > using the simple kmap_atomic to support local memory, and this setup > must be done on acquisition of the backing storage prior to entering > fence execution co

[PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Matthew Auld
We need to general our accessor for the page directories and tables from using the simple kmap_atomic to support local memory, and this setup must be done on acquisition of the backing storage prior to entering fence execution contexts. Here we replace the kmap with the object maping code that for