Re: [PATCH 17/17] drm/mgag200: Replace VRAM helpers with SHMEM helpers

2020-05-04 Thread Thomas Zimmermann
Hi Am 04.05.20 um 14:29 schrieb Emil Velikov: > Hi Thomas, > > Just a couple of fly-by comments. > > On Wed, 29 Apr 2020 at 15:33, Thomas Zimmermann wrote: > >> @@ -1618,21 +1640,13 @@ mgag200_simple_display_pipe_update(struct >> drm_simple_display_pipe *pipe, >> struct mga_device *md

Re: [PATCH 17/17] drm/mgag200: Replace VRAM helpers with SHMEM helpers

2020-05-04 Thread Emil Velikov
Hi Thomas, Just a couple of fly-by comments. On Wed, 29 Apr 2020 at 15:33, Thomas Zimmermann wrote: > @@ -1618,21 +1640,13 @@ mgag200_simple_display_pipe_update(struct > drm_simple_display_pipe *pipe, > struct mga_device *mdev = to_mga_device(dev); > struct drm_plane_state *sta

[PATCH 17/17] drm/mgag200: Replace VRAM helpers with SHMEM helpers

2020-04-29 Thread Thomas Zimmermann
The VRAM helpers managed the framebuffer memory for mgag200. This came with several problems, as some MGA device require the scanout address to be located at VRAM offset 0. It's incompatible with the page-flip semantics of DRM's atomic modesettting. With atomic modesetting, old and new framebuffers