Re: [Intel-gfx] [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-31 Thread Daniel Vetter
On Wed, May 31, 2017 at 05:37:34PM +0100, Liviu Dudau wrote: > On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote: > > IRQs are properly shut down, so it almost works as race-free shutdown. > > Except the irq is stopped after the vblank stuff, so boom anyway. > > Proper way would be to c

Re: [Intel-gfx] [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-31 Thread Daniel Vetter
On Wed, May 31, 2017 at 05:57:07PM +0100, Liviu Dudau wrote: > On Wed, May 31, 2017 at 06:41:05PM +0200, Daniel Vetter wrote: > > On Wed, May 31, 2017 at 1:22 PM, Liviu Dudau wrote: > > > On Wed, May 31, 2017 at 01:03:34PM +0200, Daniel Vetter wrote: > > >> On Wed, May 31, 2017 at 12:57 PM, Liviu

Re: [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-31 Thread Liviu Dudau
On Wed, May 31, 2017 at 06:41:05PM +0200, Daniel Vetter wrote: > On Wed, May 31, 2017 at 1:22 PM, Liviu Dudau wrote: > > On Wed, May 31, 2017 at 01:03:34PM +0200, Daniel Vetter wrote: > >> On Wed, May 31, 2017 at 12:57 PM, Liviu Dudau wrote: > >> > On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel

Re: [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-31 Thread Daniel Vetter
On Wed, May 31, 2017 at 1:22 PM, Liviu Dudau wrote: > On Wed, May 31, 2017 at 01:03:34PM +0200, Daniel Vetter wrote: >> On Wed, May 31, 2017 at 12:57 PM, Liviu Dudau wrote: >> > On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote: >> >> IRQs are properly shut down, so it almost works as

Re: [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-31 Thread Liviu Dudau
On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote: > IRQs are properly shut down, so it almost works as race-free shutdown. > Except the irq is stopped after the vblank stuff, so boom anyway. > Proper way would be to call drm_atomic_helper_shutdown before any of > the kms things gets st

Re: [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-31 Thread Liviu Dudau
On Wed, May 31, 2017 at 01:03:34PM +0200, Daniel Vetter wrote: > On Wed, May 31, 2017 at 12:57 PM, Liviu Dudau wrote: > > On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote: > >> IRQs are properly shut down, so it almost works as race-free shutdown. > >> Except the irq is stopped after

Re: [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-31 Thread Daniel Vetter
On Wed, May 31, 2017 at 12:57 PM, Liviu Dudau wrote: > On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote: >> IRQs are properly shut down, so it almost works as race-free shutdown. >> Except the irq is stopped after the vblank stuff, so boom anyway. >> Proper way would be to call drm_at

Re: [PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-31 Thread Liviu Dudau
Hi Daniel, On Wed, May 24, 2017 at 04:51:51PM +0200, Daniel Vetter wrote: > IRQs are properly shut down, so it almost works as race-free shutdown. > Except the irq is stopped after the vblank stuff, so boom anyway. > Proper way would be to call drm_atomic_helper_shutdown before any of > the kms th

[PATCH 16/37] drm/hdlcd|mali: Drop drm_vblank_cleanup

2017-05-24 Thread Daniel Vetter
IRQs are properly shut down, so it almost works as race-free shutdown. Except the irq is stopped after the vblank stuff, so boom anyway. Proper way would be to call drm_atomic_helper_shutdown before any of the kms things gets stopped. So no harm in removing the drm_vblank_cleanup here really. Same