Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-06-01 Thread Dmitry Osipenko
On 01.06.2017 20:39, Mikko Perttunen wrote: > Reviewed-by: Mikko Perttunen > > On 05/23/2017 03:14 AM, Dmitry Osipenko wrote: >> Incorrectly shifted relocation address will cause a lower memory corruption >> and likely a hang on a write or a read of an arbitrary data in case of IOMMU >> absent. A

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-06-01 Thread Dmitry Osipenko
On 01.06.2017 21:51, Mikko Perttunen wrote: > On 06/01/2017 09:44 PM, Dmitry Osipenko wrote: >> On 01.06.2017 21:37, Dmitry Osipenko wrote: >>> On 01.06.2017 20:39, Mikko Perttunen wrote: Reviewed-by: Mikko Perttunen On 05/23/2017 03:14 AM, Dmitry Osipenko wrote: > Incorrectly s

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-06-01 Thread Mikko Perttunen
On 06/01/2017 09:44 PM, Dmitry Osipenko wrote: On 01.06.2017 21:37, Dmitry Osipenko wrote: On 01.06.2017 20:39, Mikko Perttunen wrote: Reviewed-by: Mikko Perttunen On 05/23/2017 03:14 AM, Dmitry Osipenko wrote: Incorrectly shifted relocation address will cause a lower memory corruption and l

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-06-01 Thread Mikko Perttunen
Reviewed-by: Mikko Perttunen On 05/23/2017 03:14 AM, Dmitry Osipenko wrote: Incorrectly shifted relocation address will cause a lower memory corruption and likely a hang on a write or a read of an arbitrary data in case of IOMMU absent. As of now there is no use for the address shifting (at lea

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-06-01 Thread Dmitry Osipenko
On 01.06.2017 21:37, Dmitry Osipenko wrote: > On 01.06.2017 20:39, Mikko Perttunen wrote: >> Reviewed-by: Mikko Perttunen >> >> On 05/23/2017 03:14 AM, Dmitry Osipenko wrote: >>> Incorrectly shifted relocation address will cause a lower memory corruption >>> and likely a hang on a write or a read

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-05-23 Thread Dmitry Osipenko
On 23.05.2017 14:19, Mikko Perttunen wrote: > On 23.05.2017 13:58, Dmitry Osipenko wrote: >> On 23.05.2017 13:14, Mikko Perttunen wrote: >>> Reloc shifts are implemented (see assignment of u32 reloc_addr in >>> do_relocs), >>> and they are required for VIC job submissions. >>> >> >> The *validatio

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-05-23 Thread Mikko Perttunen
On 23.05.2017 13:58, Dmitry Osipenko wrote: On 23.05.2017 13:14, Mikko Perttunen wrote: Reloc shifts are implemented (see assignment of u32 reloc_addr in do_relocs), and they are required for VIC job submissions. The *validation* is unimplemented. Since VIC uses the shifts, we may add a valid

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-05-23 Thread Mikko Perttunen
Reloc shifts are implemented (see assignment of u32 reloc_addr in do_relocs), and they are required for VIC job submissions. On 23.05.2017 03:14, Dmitry Osipenko wrote: Incorrectly shifted relocation address will cause a lower memory corruption and likely a hang on a write or a read of an arbit

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-05-23 Thread Dmitry Osipenko
On 23.05.2017 13:14, Mikko Perttunen wrote: > Reloc shifts are implemented (see assignment of u32 reloc_addr in do_relocs), > and they are required for VIC job submissions. > The *validation* is unimplemented. Since VIC uses the shifts, we may add a validation for it in a way it is done for the r

[PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-05-22 Thread Dmitry Osipenko
Incorrectly shifted relocation address will cause a lower memory corruption and likely a hang on a write or a read of an arbitrary data in case of IOMMU absent. As of now there is no use for the address shifting (at least on Tegra20) and adding a proper shifting / sizes validation is much more work

Re: [PATCH 14/22] gpu: host1x: Forbid relocation address shifting in the firewall

2017-05-22 Thread Erik Faye-Lund
On Tue, May 23, 2017 at 2:14 AM, Dmitry Osipenko wrote: > Incorrectly shifted relocation address will cause a lower memory corruption > and likely a hang on a write or a read of an arbitrary data in case of IOMMU > absent. As of now there is no use for the address shifting (at least on > Tegra20)