[PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-10-03 Thread Daniel Vetter
On Sat, Oct 1, 2011 at 21:01, Keith Packard wrote: > On Sat, 1 Oct 2011 11:59:09 +0200, Daniel Vetter wrote: > >> So while you bang your head against this, can you add the backlight power >> sequencing delays for lvds panels, too? The lvds panel power sequencing >> should be imo safe - we just ms

Re: [PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-10-03 Thread Daniel Vetter
On Sat, Oct 1, 2011 at 21:01, Keith Packard wrote: > On Sat, 1 Oct 2011 11:59:09 +0200, Daniel Vetter wrote: > >> So while you bang your head against this, can you add the backlight power >> sequencing delays for lvds panels, too? The lvds panel power sequencing >> should be imo safe - we just ms

Re: [PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-10-01 Thread Keith Packard
On Sat, 1 Oct 2011 11:59:09 +0200, Daniel Vetter wrote: > So while you bang your head against this, can you add the backlight power > sequencing delays for lvds panels, too? The lvds panel power sequencing > should be imo safe - we just msleep-spin with wait_for until the power > sequencer has co

[PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-10-01 Thread Keith Packard
On Sat, 1 Oct 2011 11:59:09 +0200, Daniel Vetter wrote: > So while you bang your head against this, can you add the backlight power > sequencing delays for lvds panels, too? The lvds panel power sequencing > should be imo safe - we just msleep-spin with wait_for until the power > sequencer has co

[PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-10-01 Thread Daniel Vetter
On Fri, Sep 30, 2011 at 08:31:13PM -0700, Keith Packard wrote: > On Fri, 30 Sep 2011 20:16:44 +0200, Daniel Vetter wrote: > > > Awesome patch description and the code agrees with what I've cross-checked > > on bspec. The only fear I have is that we currently ignore the backlight > > on/off timing

Re: [PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-10-01 Thread Daniel Vetter
On Fri, Sep 30, 2011 at 08:31:13PM -0700, Keith Packard wrote: > On Fri, 30 Sep 2011 20:16:44 +0200, Daniel Vetter wrote: > > > Awesome patch description and the code agrees with what I've cross-checked > > on bspec. The only fear I have is that we currently ignore the backlight > > on/off timing

Re: [PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 20:16:44 +0200, Daniel Vetter wrote: > Awesome patch description and the code agrees with what I've cross-checked > on bspec. The only fear I have is that we currently ignore the backlight > on/off timings and some panel probably relies on use waiting for backlight > on/off +

[PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 20:16:44 +0200, Daniel Vetter wrote: > Awesome patch description and the code agrees with what I've cross-checked > on bspec. The only fear I have is that we currently ignore the backlight > on/off timings and some panel probably relies on use waiting for backlight > on/off +

[PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:46PM -0700, Keith Packard wrote: > Store the panel power sequencing delays in the dp private structure, > rather than the global device structure. Who knows, maybe we'll get > more than one eDP device in the future. > > Look at both the current hardware register setti

Re: [PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 20:16:44 +0200, Daniel Vetter wrote: > Awesome patch description and the code agrees with what I've cross-checked > on bspec. The only fear I have is that we currently ignore the backlight > on/off timings and some panel probably relies on use waiting for backlight > on/off +

[PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-30 Thread Keith Packard
On Fri, 30 Sep 2011 20:16:44 +0200, Daniel Vetter wrote: > Awesome patch description and the code agrees with what I've cross-checked > on bspec. The only fear I have is that we currently ignore the backlight > on/off timings and some panel probably relies on use waiting for backlight > on/off +

Re: [PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-30 Thread Daniel Vetter
On Thu, Sep 29, 2011 at 06:09:46PM -0700, Keith Packard wrote: > Store the panel power sequencing delays in the dp private structure, > rather than the global device structure. Who knows, maybe we'll get > more than one eDP device in the future. > > Look at both the current hardware register setti

[PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-29 Thread Keith Packard
Store the panel power sequencing delays in the dp private structure, rather than the global device structure. Who knows, maybe we'll get more than one eDP device in the future. Look at both the current hardware register settings and the VBT specified panel power sequencing timings. Use the maximum

[PATCH 14/21] drm/i915: Correct eDP panel power sequencing delay computations

2011-09-29 Thread Keith Packard
Store the panel power sequencing delays in the dp private structure, rather than the global device structure. Who knows, maybe we'll get more than one eDP device in the future. Look at both the current hardware register settings and the VBT specified panel power sequencing timings. Use the maximum