[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-04 Thread Sascha Hauer
On Fri, Feb 03, 2012 at 10:08:12AM +, Dave Airlie wrote: > On Wed, Feb 1, 2012 at 1:05 PM, Sascha Hauer > wrote: > > On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: > >> > >> > >> > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > >> > > index 8d593ad..cdbbb40 10

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-03 Thread Sascha Hauer
On Fri, Feb 03, 2012 at 10:08:12AM +, Dave Airlie wrote: > On Wed, Feb 1, 2012 at 1:05 PM, Sascha Hauer wrote: > > On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: > >> > >> > >> > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > >> > > index 8d593ad..cdbbb40 10064

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-03 Thread Dave Airlie
On Wed, Feb 1, 2012 at 1:05 PM, Sascha Hauer wrote: > On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: >> >> >> > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h >> > > index 8d593ad..cdbbb40 100644 >> > > --- a/include/drm/drm_crtc.h >> > > +++ b/include/drm/drm_crtc.h

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-03 Thread Dave Airlie
On Wed, Feb 1, 2012 at 1:05 PM, Sascha Hauer wrote: > On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: >> >> >> > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h >> > > index 8d593ad..cdbbb40 100644 >> > > --- a/include/drm/drm_crtc.h >> > > +++ b/include/drm/drm_crtc.h

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Daniel Vetter
On Wed, Feb 01, 2012 at 02:05:38PM +0100, Sascha Hauer wrote: > On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: > > > > > > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > > > index 8d593ad..cdbbb40 100644 > > > > --- a/include/drm/drm_crtc.h > > > > +++ b/inclu

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: > > > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > > index 8d593ad..cdbbb40 100644 > > > --- a/include/drm/drm_crtc.h > > > +++ b/include/drm/drm_crtc.h > > > @@ -394,7 +394,7 @@ struct drm_crtc { > > > s64 fr

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
On Wed, Feb 01, 2012 at 11:48:53AM +, Chris Wilson wrote: > On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer > wrote: > > Creating an enum property is a common pattern, so create > > a convenience function for this and use it where appropriate. > > Similar naming comments apply as for drm_pr

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Chris Wilson
On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer wrote: > Creating an enum property is a common pattern, so create > a convenience function for this and use it where appropriate. Similar naming comments apply as for drm_property_create_range. However, I did spot something anomalous... > diff --

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
Creating an enum property is a common pattern, so create a convenience function for this and use it where appropriate. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/drm_crtc.c| 100 +--- drivers/gpu/drm/i915/intel_modes.c| 28 +++- drivers

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread David Airlie
- Original Message - > From: "Chris Wilson" > To: "Sascha Hauer" , dri-devel at > lists.freedesktop.org > Cc: kernel at pengutronix.de > Sent: Wednesday, 1 February, 2012 11:48:53 AM > Subject: Re: [PATCH 14/20] drm: add convenience function to cre

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Daniel Vetter
On Wed, Feb 01, 2012 at 02:05:38PM +0100, Sascha Hauer wrote: > On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: > > > > > > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > > > index 8d593ad..cdbbb40 100644 > > > > --- a/include/drm/drm_crtc.h > > > > +++ b/inclu

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: > > > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > > index 8d593ad..cdbbb40 100644 > > > --- a/include/drm/drm_crtc.h > > > +++ b/include/drm/drm_crtc.h > > > @@ -394,7 +394,7 @@ struct drm_crtc { > > > s64 fr

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread David Airlie
- Original Message - > From: "Chris Wilson" > To: "Sascha Hauer" , dri-devel@lists.freedesktop.org > Cc: ker...@pengutronix.de > Sent: Wednesday, 1 February, 2012 11:48:53 AM > Subject: Re: [PATCH 14/20] drm: add convenience function to create an enum

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
On Wed, Feb 01, 2012 at 11:48:53AM +, Chris Wilson wrote: > On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer > wrote: > > Creating an enum property is a common pattern, so create > > a convenience function for this and use it where appropriate. > > Similar naming comments apply as for drm_pr

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Chris Wilson
On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer wrote: > Creating an enum property is a common pattern, so create > a convenience function for this and use it where appropriate. Similar naming comments apply as for drm_property_create_range. However, I did spot something anomalous... > diff --g

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
Creating an enum property is a common pattern, so create a convenience function for this and use it where appropriate. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/drm_crtc.c| 100 +--- drivers/gpu/drm/i915/intel_modes.c| 28 +++- drivers