[PATCH 14/17] drm/msm: add atomic support

2014-05-28 Thread Ville Syrjälä
On Wed, May 28, 2014 at 03:21:41PM +0200, Daniel Vetter wrote: > On Tue, May 27, 2014 at 07:32:46PM -0400, Rob Clark wrote: > > On Tue, May 27, 2014 at 6:09 PM, Daniel Vetter wrote: > > > On Tue, May 27, 2014 at 04:06:28PM -0400, Rob Clark wrote: > > >> On Tue, May 27, 2014 at 3:26 PM, Daniel Vett

[PATCH 14/17] drm/msm: add atomic support

2014-05-28 Thread Daniel Vetter
On Wed, May 28, 2014 at 05:14:21PM +0300, Ville Syrj?l? wrote: > On Wed, May 28, 2014 at 03:21:41PM +0200, Daniel Vetter wrote: > > On Tue, May 27, 2014 at 07:32:46PM -0400, Rob Clark wrote: > > > On Tue, May 27, 2014 at 6:09 PM, Daniel Vetter wrote: > > > > On Tue, May 27, 2014 at 04:06:28PM -040

[PATCH 14/17] drm/msm: add atomic support

2014-05-28 Thread Daniel Vetter
On Tue, May 27, 2014 at 07:47:42PM -0400, Rob Clark wrote: > On Tue, May 27, 2014 at 6:09 PM, Daniel Vetter wrote: > > On Tue, May 27, 2014 at 04:06:28PM -0400, Rob Clark wrote: > >> On Tue, May 27, 2014 at 3:26 PM, Daniel Vetter wrote: > > > > [snip] > > > >> Well, there was the NONBLOCK atomic

[PATCH 14/17] drm/msm: add atomic support

2014-05-28 Thread Daniel Vetter
On Tue, May 27, 2014 at 07:32:46PM -0400, Rob Clark wrote: > On Tue, May 27, 2014 at 6:09 PM, Daniel Vetter wrote: > > On Tue, May 27, 2014 at 04:06:28PM -0400, Rob Clark wrote: > >> On Tue, May 27, 2014 at 3:26 PM, Daniel Vetter wrote: > > > > [snip] > > > >> Well, there was the NONBLOCK atomic

[PATCH 14/17] drm/msm: add atomic support

2014-05-28 Thread Rob Clark
On Wed, May 28, 2014 at 9:21 AM, Daniel Vetter wrote: > On Tue, May 27, 2014 at 07:32:46PM -0400, Rob Clark wrote: >> On Tue, May 27, 2014 at 6:09 PM, Daniel Vetter wrote: >> > On Tue, May 27, 2014 at 04:06:28PM -0400, Rob Clark wrote: >> >> On Tue, May 27, 2014 at 3:26 PM, Daniel Vetter wrote:

[PATCH 14/17] drm/msm: add atomic support

2014-05-28 Thread Daniel Vetter
On Tue, May 27, 2014 at 04:06:28PM -0400, Rob Clark wrote: > On Tue, May 27, 2014 at 3:26 PM, Daniel Vetter wrote: [snip] > Well, there was the NONBLOCK atomic flag.. I'm not entirely sure if we > should hang so much off of that one flag. Yeah, a separate VBLANK_SYNCED might be useful. Apparent

[PATCH 14/17] drm/msm: add atomic support

2014-05-27 Thread Daniel Vetter
On Tue, May 27, 2014 at 02:48:41PM -0400, Rob Clark wrote: > On Tue, May 27, 2014 at 1:50 PM, Daniel Vetter wrote: > > On Tue, May 27, 2014 at 11:58:33AM -0400, Rob Clark wrote: > >> On Mon, May 26, 2014 at 1:54 PM, Daniel Vetter wrote: > >> > Ok, I think I should have read your msm implementatio

[PATCH 14/17] drm/msm: add atomic support

2014-05-27 Thread Daniel Vetter
On Tue, May 27, 2014 at 11:58:33AM -0400, Rob Clark wrote: > On Mon, May 26, 2014 at 1:54 PM, Daniel Vetter wrote: > > Ok, I think I should have read your msm implementation a _lot_ earlier. > > Explains your desing choices neatly. > > > > Two observations: > > > > - A GO bit makes nuclear pagefli

[PATCH 14/17] drm/msm: add atomic support

2014-05-27 Thread Rob Clark
On Tue, May 27, 2014 at 6:09 PM, Daniel Vetter wrote: > On Tue, May 27, 2014 at 04:06:28PM -0400, Rob Clark wrote: >> On Tue, May 27, 2014 at 3:26 PM, Daniel Vetter wrote: > > [snip] > >> Well, there was the NONBLOCK atomic flag.. I'm not entirely sure if we >> should hang so much off of that one

[PATCH 14/17] drm/msm: add atomic support

2014-05-27 Thread Rob Clark
On Tue, May 27, 2014 at 6:09 PM, Daniel Vetter wrote: > On Tue, May 27, 2014 at 04:06:28PM -0400, Rob Clark wrote: >> On Tue, May 27, 2014 at 3:26 PM, Daniel Vetter wrote: > > [snip] > >> Well, there was the NONBLOCK atomic flag.. I'm not entirely sure if we >> should hang so much off of that one

[PATCH 14/17] drm/msm: add atomic support

2014-05-27 Thread Rob Clark
On Tue, May 27, 2014 at 3:26 PM, Daniel Vetter wrote: > On Tue, May 27, 2014 at 02:48:41PM -0400, Rob Clark wrote: >> On Tue, May 27, 2014 at 1:50 PM, Daniel Vetter wrote: >> > On Tue, May 27, 2014 at 11:58:33AM -0400, Rob Clark wrote: >> >> On Mon, May 26, 2014 at 1:54 PM, Daniel Vetter wrote:

[PATCH 14/17] drm/msm: add atomic support

2014-05-27 Thread Rob Clark
On Tue, May 27, 2014 at 1:50 PM, Daniel Vetter wrote: > On Tue, May 27, 2014 at 11:58:33AM -0400, Rob Clark wrote: >> On Mon, May 26, 2014 at 1:54 PM, Daniel Vetter wrote: >> > Ok, I think I should have read your msm implementation a _lot_ earlier. >> > Explains your desing choices neatly. >> > >

[PATCH 14/17] drm/msm: add atomic support

2014-05-27 Thread Rob Clark
On Mon, May 26, 2014 at 1:54 PM, Daniel Vetter wrote: > On Sat, May 24, 2014 at 02:30:23PM -0400, Rob Clark wrote: >> Signed-off-by: Rob Clark >> --- >> drivers/gpu/drm/msm/Makefile | 1 + >> drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 57 ++-- >> drivers/gpu/drm/msm/mdp/

[PATCH 14/17] drm/msm: add atomic support

2014-05-26 Thread Daniel Vetter
On Sat, May 24, 2014 at 02:30:23PM -0400, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/Makefile | 1 + > drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 57 ++-- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 6 ++ > drivers/gpu/drm/msm/mdp/mdp4/mdp

[PATCH 14/17] drm/msm: add atomic support

2014-05-24 Thread Rob Clark
Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 57 ++-- drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 6 ++ drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.h | 1 + drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 5 --