[PATCH 13/13 v4] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

2012-03-28 Thread Daniel Kurtz
On Wed, Mar 28, 2012 at 3:02 AM, Chris Wilson wrote: > On Wed, 28 Mar 2012 02:36:22 +0800, Daniel Kurtz > wrote: >> Save the GMBUS2 value read while polling for state changes, and then >> reuse this value when determining for which reason the loops were exited. >> This is a small optimization w

[PATCH 13/13 v4] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

2012-03-28 Thread Chris Wilson
On Wed, 28 Mar 2012 19:39:17 +0800, Daniel Kurtz wrote: > On Wed, Mar 28, 2012 at 3:02 AM, Chris Wilson > wrote: > > Might as well shave this read as well. > > Do you know why POSTING_READ() was there in the first place? > As far as I can tell, these are used to ensure memory barriers are > in

Re: [PATCH 13/13 v4] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

2012-03-28 Thread Daniel Kurtz
On Wed, Mar 28, 2012 at 3:02 AM, Chris Wilson wrote: > On Wed, 28 Mar 2012 02:36:22 +0800, Daniel Kurtz wrote: >> Save the GMBUS2 value read while polling for state changes, and then >> reuse this value when determining for which reason the loops were exited. >> This is a small optimization which

Re: [PATCH 13/13 v4] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

2012-03-28 Thread Chris Wilson
On Wed, 28 Mar 2012 19:39:17 +0800, Daniel Kurtz wrote: > On Wed, Mar 28, 2012 at 3:02 AM, Chris Wilson > wrote: > > Might as well shave this read as well. > > Do you know why POSTING_READ() was there in the first place? > As far as I can tell, these are used to ensure memory barriers are > ins

[PATCH 13/13 v4] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

2012-03-28 Thread Daniel Kurtz
Save the GMBUS2 value read while polling for state changes, and then reuse this value when determining for which reason the loops were exited. This is a small optimization which saves a couple of bus accesses for memory mapped IO registers. To avoid "assigning in if clause" checkpatch errors", use

[PATCH 13/13 v4] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

2012-03-27 Thread Daniel Kurtz
Save the GMBUS2 value read while polling for state changes, and then reuse this value when determining for which reason the loops were exited. This is a small optimization which saves a couple of bus accesses for memory mapped IO registers. To avoid "assigning in if clause" checkpatch errors", use

[PATCH 13/13 v4] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

2012-03-27 Thread Chris Wilson
On Wed, 28 Mar 2012 02:36:22 +0800, Daniel Kurtz wrote: > Save the GMBUS2 value read while polling for state changes, and then > reuse this value when determining for which reason the loops were exited. > This is a small optimization which saves a couple of bus accesses for > memory mapped IO reg

Re: [PATCH 13/13 v4] drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop

2012-03-27 Thread Chris Wilson
On Wed, 28 Mar 2012 02:36:22 +0800, Daniel Kurtz wrote: > Save the GMBUS2 value read while polling for state changes, and then > reuse this value when determining for which reason the loops were exited. > This is a small optimization which saves a couple of bus accesses for > memory mapped IO regi