Re: [PATCH 13/13] drm/vblank: Unexport drm_vblank_cleanup

2017-06-22 Thread Alex Deucher
On Wed, Jun 21, 2017 at 4:28 AM, Daniel Vetter wrote: > There's no reason for drivers to call this, and all the ones I've > removed looked very fishy: > - Proper quiescenting of the vblank machinery should be done by > calling drm_crtc_vblank_off(), which is best done by shutting down > the en

[PATCH 13/13] drm/vblank: Unexport drm_vblank_cleanup

2017-06-21 Thread Daniel Vetter
There's no reason for drivers to call this, and all the ones I've removed looked very fishy: - Proper quiescenting of the vblank machinery should be done by calling drm_crtc_vblank_off(), which is best done by shutting down the entire display engine with drm_atomic_helper_shutdown. - Releasing