Re: [PATCH 10/15] v4l: vsp1: Move DRM pipeline output setup code to a function

2018-04-04 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 4 April 2018 19:15:19 EEST Kieran Bingham wrote: > On 02/04/18 13:35, Laurent Pinchart wrote: > > > > >>> +/* Setup the output side of the pipeline (WPF and LIF). */ > >>> +static int vsp1_du_pipeline_setup_output(struct vsp1_device *vsp1, > >>> +

Re: [PATCH 10/15] v4l: vsp1: Move DRM pipeline output setup code to a function

2018-04-04 Thread Kieran Bingham
Hi Laurent, On 02/04/18 13:35, Laurent Pinchart wrote: >>> +/* Setup the output side of the pipeline (WPF and LIF). */ >>> +static int vsp1_du_pipeline_setup_output(struct vsp1_device *vsp1, >>> +struct vsp1_pipeline *pipe) >>> +{ >>> + struct vsp1_drm_pipe

Re: [PATCH 10/15] v4l: vsp1: Move DRM pipeline output setup code to a function

2018-04-02 Thread Laurent Pinchart
Hi Kieran, On Thursday, 29 March 2018 14:49:12 EEST Kieran Bingham wrote: > Hi Laurent, > > Thank you for another patch :D You're welcome, there will be more ;-) > On 26/02/18 21:45, Laurent Pinchart wrote: > > In order to make the vsp1_du_setup_lif() easier to read, and for > > symmetry with t

Re: [PATCH 10/15] v4l: vsp1: Move DRM pipeline output setup code to a function

2018-03-29 Thread Kieran Bingham
Hi Laurent, Thank you for another patch :D On 26/02/18 21:45, Laurent Pinchart wrote: > In order to make the vsp1_du_setup_lif() easier to read, and for > symmetry with the DRM pipeline input setup, move the pipeline output > setup code to a separate function. > > Signed-off-by: Laurent Pinchart

[PATCH 10/15] v4l: vsp1: Move DRM pipeline output setup code to a function

2018-02-26 Thread Laurent Pinchart
In order to make the vsp1_du_setup_lif() easier to read, and for symmetry with the DRM pipeline input setup, move the pipeline output setup code to a separate function. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_drm.c | 107 +++-- 1 file chan