Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-09 Thread Jason Gunthorpe
On Thu, Oct 08, 2020 at 12:49:54AM -0700, Dan Williams wrote: > > This is what got me thinking maybe this needs to be a bit bigger > > generic infrastructure - eg enter this scheme from fops mmap and > > everything else is in mm/user_iomem.c > > It still requires every file that can map physical

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-08 Thread Dan Williams
On Thu, Oct 8, 2020 at 1:13 AM Daniel Vetter wrote: > > On Thu, Oct 8, 2020 at 9:50 AM Dan Williams wrote: > > > > On Wed, Oct 7, 2020 at 4:25 PM Jason Gunthorpe wrote: > > > > > > On Wed, Oct 07, 2020 at 12:33:06PM -0700, Dan Williams wrote: > > > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-08 Thread Daniel Vetter
On Thu, Oct 8, 2020 at 9:50 AM Dan Williams wrote: > > On Wed, Oct 7, 2020 at 4:25 PM Jason Gunthorpe wrote: > > > > On Wed, Oct 07, 2020 at 12:33:06PM -0700, Dan Williams wrote: > > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter > > > wrote: > > > > > > > > Since 3234ac664a87 ("/dev/mem: Revo

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-08 Thread Daniel Vetter
On Thu, Oct 8, 2020 at 12:29 AM Dan Williams wrote: > > On Wed, Oct 7, 2020 at 3:23 PM Dan Williams wrote: > > > > On Wed, Oct 7, 2020 at 12:49 PM Daniel Vetter > > wrote: > > > > > > On Wed, Oct 7, 2020 at 9:33 PM Dan Williams > > > wrote: > > > > > > > > On Wed, Oct 7, 2020 at 11:11 AM Dani

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-08 Thread Dan Williams
On Wed, Oct 7, 2020 at 4:25 PM Jason Gunthorpe wrote: > > On Wed, Oct 07, 2020 at 12:33:06PM -0700, Dan Williams wrote: > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter > > wrote: > > > > > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > > the region") /dev/kmem zaps p

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-08 Thread Daniel Vetter
On Thu, Oct 8, 2020 at 1:24 AM Jason Gunthorpe wrote: > > On Wed, Oct 07, 2020 at 12:33:06PM -0700, Dan Williams wrote: > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter > > wrote: > > > > > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > > the region") /dev/kmem zaps p

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-08 Thread Jason Gunthorpe
On Wed, Oct 07, 2020 at 12:33:06PM -0700, Dan Williams wrote: > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter wrote: > > > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > the region") /dev/kmem zaps ptes when the kernel requests exclusive > > acccess to an iomem region. A

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-07 Thread Dan Williams
On Wed, Oct 7, 2020 at 3:23 PM Dan Williams wrote: > > On Wed, Oct 7, 2020 at 12:49 PM Daniel Vetter wrote: > > > > On Wed, Oct 7, 2020 at 9:33 PM Dan Williams > > wrote: > > > > > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter > > > wrote: > > > > > > > > Since 3234ac664a87 ("/dev/mem: Revo

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-07 Thread Dan Williams
On Wed, Oct 7, 2020 at 12:49 PM Daniel Vetter wrote: > > On Wed, Oct 7, 2020 at 9:33 PM Dan Williams wrote: > > > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter > > wrote: > > > > > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > > the region") /dev/kmem zaps ptes whe

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-07 Thread Daniel Vetter
On Wed, Oct 7, 2020 at 9:33 PM Dan Williams wrote: > > On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter wrote: > > > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > the region") /dev/kmem zaps ptes when the kernel requests exclusive > > acccess to an iomem region. And with

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-07 Thread Dan Williams
On Wed, Oct 7, 2020 at 11:11 AM Daniel Vetter wrote: > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > the region") /dev/kmem zaps ptes when the kernel requests exclusive > acccess to an iomem region. And with CONFIG_IO_STRICT_DEVMEM, this is > the default for all driver us

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-07 Thread Daniel Vetter
On Wed, Oct 7, 2020 at 8:41 PM Bjorn Helgaas wrote: > > Capitalize subject, like other patches in this series and previous > drivers/pci history. > > On Wed, Oct 07, 2020 at 06:44:23PM +0200, Daniel Vetter wrote: > > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > > the regio

Re: [PATCH 10/13] PCI: revoke mappings like devmem

2020-10-07 Thread Bjorn Helgaas
Capitalize subject, like other patches in this series and previous drivers/pci history. On Wed, Oct 07, 2020 at 06:44:23PM +0200, Daniel Vetter wrote: > Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims > the region") /dev/kmem zaps ptes when the kernel requests exclusive > accce

[PATCH 10/13] PCI: revoke mappings like devmem

2020-10-07 Thread Daniel Vetter
Since 3234ac664a87 ("/dev/mem: Revoke mappings when a driver claims the region") /dev/kmem zaps ptes when the kernel requests exclusive acccess to an iomem region. And with CONFIG_IO_STRICT_DEVMEM, this is the default for all driver uses. Except there's two more ways to access pci bars: sysfs and