Re: [PATCH 10/10] drm: Use state helper instead of the plane state pointer

2021-01-21 Thread Maxime Ripard
Hi Laurent, On Fri, Jan 15, 2021 at 11:20:21PM +0200, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Fri, Jan 15, 2021 at 01:57:02PM +0100, Maxime Ripard wrote: > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atom

[PATCH 10/10] drm: Use state helper instead of the plane state pointer

2021-01-16 Thread Maxime Ripard
Many drivers reference the plane->state pointer in order to get the current plane state in their atomic_update or atomic_disable hooks, which would be the new plane state in the global atomic state since _swap_state happened when those hooks are run. Use the drm_atomic_get_new_plane_state helper t

Re: [PATCH 10/10] drm: Use state helper instead of the plane state pointer

2021-01-15 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Fri, Jan 15, 2021 at 01:57:02PM +0100, Maxime Ripard wrote: > Many drivers reference the plane->state pointer in order to get the > current plane state in their atomic_update or atomic_disable hooks, Please don't use the word "current", it's ambiguous. Do y