Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Marek Vasut
On 3/3/22 09:21, Lucas Stach wrote: Am Donnerstag, dem 03.03.2022 um 04:14 +0100 schrieb Marek Vasut: On 3/2/22 10:23, Lucas Stach wrote: [...] I tend to agree with Marek on this one. We have an instance where the blk-ctrl and the GPC driver between 8m, mini, nano, plus are close, but differ

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Liu Ying
On Thu, 2022-03-03 at 09:19 +0100, Lucas Stach wrote: > Am Donnerstag, dem 03.03.2022 um 10:54 +0800 schrieb Liu Ying: > > On Wed, 2022-03-02 at 12:57 +0100, Lucas Stach wrote: > > > Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: > > > > On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach

RE: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Robby Cai
>-Original Message- >From: Marek Vasut >Sent: 2022年3月2日 10:50 >To: Robby Cai ; Lucas Stach ; >Adam Ford >Cc: Ying Liu (OSS) ; dri-devel >; devicetree ; >Peng Fan ; Alexander Stein >; Rob Herring ; >Laurent Pinchart ; Sam Ravnborg > >Subject: Re: [EXT

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Lucas Stach
Am Donnerstag, dem 03.03.2022 um 04:14 +0100 schrieb Marek Vasut: > On 3/2/22 10:23, Lucas Stach wrote: > > [...] > > > > > > I tend to agree with Marek on this one. We have an instance where the > > > > > blk-ctrl and the GPC driver between 8m, mini, nano, plus are close, > > > > > but differen

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-03 Thread Lucas Stach
Am Donnerstag, dem 03.03.2022 um 10:54 +0800 schrieb Liu Ying: > On Wed, 2022-03-02 at 12:57 +0100, Lucas Stach wrote: > > Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: > > > On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: > > > > Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schr

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Marek Vasut
On 3/3/22 03:54, Liu Ying wrote: On Wed, 2022-03-02 at 12:57 +0100, Lucas Stach wrote: Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: On 3/1/22 14:18, Lucas Stac

Re: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Marek Vasut
On 3/2/22 14:14, Robby Cai wrote: Hi [...] LCDIF on i.MX8MP is a different IP which is borrowed from non-iMX series, although it's also called 'LCDIF'. We prefer not mix these two series of IPs in one driver for ease of maintenance and extension. Where does the MX8MP LCDIF come from then,

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Marek Vasut
On 3/2/22 10:23, Lucas Stach wrote: [...] I tend to agree with Marek on this one. We have an instance where the blk-ctrl and the GPC driver between 8m, mini, nano, plus are close, but different enough where each SoC has it's own set of tables and some checks. Lucas created the framework, and

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Liu Ying
On Wed, 2022-03-02 at 12:57 +0100, Lucas Stach wrote: > Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: > > On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: > > > Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: > > > > On 3/1/22 14:18, Lucas Stach wrote: > > > > >

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Lucas Stach
Am Mittwoch, dem 02.03.2022 um 17:41 +0800 schrieb Liu Ying: > On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: > > Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: > > > On 3/1/22 14:18, Lucas Stach wrote: > > > > Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: >

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Liu Ying
On Wed, 2022-03-02 at 10:23 +0100, Lucas Stach wrote: > Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: > > On 3/1/22 14:18, Lucas Stach wrote: > > > Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: > > > > On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach > > > > wrote: > >

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Lucas Stach
Am Mittwoch, dem 02.03.2022 um 03:54 +0100 schrieb Marek Vasut: > On 3/1/22 14:18, Lucas Stach wrote: > > Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: > > > On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach wrote: > > > > > > > > Am Dienstag, dem 01.03.2022 um 11:19 +0100 schrieb Marek

RE: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-02 Thread Robby Cai
>-Original Message- >From: Lucas Stach >Sent: 2022年3月1日 21:19 >To: Adam Ford >Cc: Marek Vasut ; Ying Liu (OSS) ; >dri-devel ; devicetree >; Peng Fan ; Alexander Stein >; Rob Herring ; >Laurent Pinchart ; Sam Ravnborg >; Robby Cai >Subject: [EXT] Re: [P

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Marek Vasut
On 3/1/22 14:18, Lucas Stach wrote: Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach wrote: Am Dienstag, dem 01.03.2022 um 11:19 +0100 schrieb Marek Vasut: On 3/1/22 11:04, Lucas Stach wrote: Hi, [...] Given the two totally differen

Re: [EXT] Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Marek Vasut
On 3/1/22 14:37, Robby Cai wrote: Hi, [...] I tend to agree with Marek on this one. We have an instance where the blk-ctrl and the GPC driver between 8m, mini, nano, plus are close, but different enough where each SoC has it's own set of tables and some checks. Lucas created the framework,

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Lucas Stach
Am Dienstag, dem 01.03.2022 um 07:03 -0600 schrieb Adam Ford: > On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach wrote: > > > > Am Dienstag, dem 01.03.2022 um 11:19 +0100 schrieb Marek Vasut: > > > On 3/1/22 11:04, Lucas Stach wrote: > > > > > > Hi, > > > > > > [...] > > > > > > > > Given the two to

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Adam Ford
On Tue, Mar 1, 2022 at 5:05 AM Lucas Stach wrote: > > Am Dienstag, dem 01.03.2022 um 11:19 +0100 schrieb Marek Vasut: > > On 3/1/22 11:04, Lucas Stach wrote: > > > > Hi, > > > > [...] > > > > > > Given the two totally different IPs, I don't see bugs of IP control > > > > logics should be fixed for

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Lucas Stach
Am Dienstag, dem 01.03.2022 um 11:19 +0100 schrieb Marek Vasut: > On 3/1/22 11:04, Lucas Stach wrote: > > Hi, > > [...] > > > > Given the two totally different IPs, I don't see bugs of IP control > > > logics should be fixed for both drivers. Naturally, the two would > > > diverge due to differe

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Marek Vasut
On 3/1/22 11:04, Lucas Stach wrote: Hi, [...] Given the two totally different IPs, I don't see bugs of IP control logics should be fixed for both drivers. Naturally, the two would diverge due to different HWs. Looking at Patch 9/9, it basically squashes code to control LCDIFv3 into the mxsfb d

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-03-01 Thread Lucas Stach
Hi Marek, hi Liu, Am Dienstag, dem 01.03.2022 um 10:44 +0800 schrieb Liu Ying: > On Mon, 2022-02-28 at 16:34 +0100, Marek Vasut wrote: > > On 2/28/22 09:18, Liu Ying wrote: > > > > Hi, > > Hi, > > > > > > > > On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: > > > > > > Add compatible stri

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-28 Thread Liu Ying
On Mon, 2022-02-28 at 16:34 +0100, Marek Vasut wrote: > On 2/28/22 09:18, Liu Ying wrote: > > Hi, Hi, > > > > > On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: > > > > > Add compatible string for i.MX8MP LCDIF variant. This is called > > > > > LCDIFv3 > > > > > and is completely differen

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-28 Thread Marek Vasut
On 2/28/22 09:18, Liu Ying wrote: Hi, On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it In i.MX23 reference manual, there is no LCDIFv3 found, b

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-28 Thread Liu Ying
On Mon, 2022-02-28 at 07:57 +0100, Marek Vasut wrote: > On 2/28/22 07:37, Liu Ying wrote: > > Hi Marek, > > Hi, > > > On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: > > > Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 > > > and is completely different from the LCDI

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-27 Thread Marek Vasut
On 2/28/22 07:37, Liu Ying wrote: Hi Marek, Hi, On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it In i.MX23 reference manual, there is no LCDI

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-27 Thread Laurent Pinchart
Hi Marek, Thank you for the patch. On Mon, Feb 28, 2022 at 01:45:57AM +0100, Marek Vasut wrote: > Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 > and is completely different from the LCDIFv3 found in i.MX23 in that it > has a completely scrambled register layout compared

Re: [PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-27 Thread Liu Ying
Hi Marek, On Mon, 2022-02-28 at 01:45 +0100, Marek Vasut wrote: > Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 > and is completely different from the LCDIFv3 found in i.MX23 in that it In i.MX23 reference manual, there is no LCDIFv3 found, but only LCDIF. > has a compl

[PATCH 1/9] dt-bindings: mxsfb: Add compatible for i.MX8MP

2022-02-27 Thread Marek Vasut
Add compatible string for i.MX8MP LCDIF variant. This is called LCDIFv3 and is completely different from the LCDIFv3 found in i.MX23 in that it has a completely scrambled register layout compared to all previous LCDIF variants. The new LCDIFv3 also supports 36bit address space. However, except for