Re: [PATCH 1/9] drm/msm: Don't call dma_buf_vunmap without _vmap

2020-05-11 Thread Rob Clark
On Mon, May 11, 2020 at 8:29 AM Daniel Vetter wrote: > > On Mon, May 11, 2020 at 5:24 PM Rob Clark wrote: > > > > On Mon, May 11, 2020 at 2:36 AM Daniel Vetter > > wrote: > > > > > > I honestly don't exactly understand what's going on here, but the > > > current code is wrong for sure: It calls

Re: [PATCH 1/9] drm/msm: Don't call dma_buf_vunmap without _vmap

2020-05-11 Thread Daniel Vetter
On Mon, May 11, 2020 at 5:24 PM Rob Clark wrote: > > On Mon, May 11, 2020 at 2:36 AM Daniel Vetter wrote: > > > > I honestly don't exactly understand what's going on here, but the > > current code is wrong for sure: It calls dma_buf_vunmap without ever > > calling dma_buf_vmap. > > > > What I'm n

Re: [PATCH 1/9] drm/msm: Don't call dma_buf_vunmap without _vmap

2020-05-11 Thread Rob Clark
On Mon, May 11, 2020 at 2:36 AM Daniel Vetter wrote: > > I honestly don't exactly understand what's going on here, but the > current code is wrong for sure: It calls dma_buf_vunmap without ever > calling dma_buf_vmap. > > What I'm not sure about is whether the WARN_ON is correct: > - msm imports d

[PATCH 1/9] drm/msm: Don't call dma_buf_vunmap without _vmap

2020-05-11 Thread Daniel Vetter
I honestly don't exactly understand what's going on here, but the current code is wrong for sure: It calls dma_buf_vunmap without ever calling dma_buf_vmap. What I'm not sure about is whether the WARN_ON is correct: - msm imports dma-buf using drm_prime_sg_to_page_addr_arrays. Which is a pretty