Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-22 Thread Christian König
age Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 From: Christian König To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" CC: kbuild-...@01.org,dri-devel@lists.freedesktop.org,amd-...@lists.freedesktop.org,lionel.g.landwer...@intel.c

Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-22 Thread zhoucm1
silences the warning. Christian. Am 21.03.19 um 15:13 schrieb Zhou, David(ChunMing): cmpxchg be replaced by some simple c sentance? otherwise we have to remove __rcu of chian->prev. -David Original Message Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 F

Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-21 Thread Christian König
simple c sentance? otherwise we have to remove __rcu of chian->prev. -David Original Message Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 From: Christian König To: "Zhou, David(ChunMing)" ,kbuild test robot ,"Zhou, David(ChunMing)" CC:

Re:[PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-21 Thread Zhou, David(ChunMing)
cmpxchg be replaced by some simple c sentance? otherwise we have to remove __rcu of chian->prev. -David Original Message Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 From: Christian König To: "Zhou, David(ChunMing)" ,kbuild test robot

Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-21 Thread Christian König
Hi David, For the cmpxchg() case I of hand don't know either. Looks like so far nobody has used cmpxchg() with rcu protected structures. The other cases should be replaced by RCU_INIT_POINTER() or rcu_dereference_protected(.., true); Regards, Christian. Am 21.03.19 um 07:34 schrieb zhoucm1

Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-20 Thread zhoucm1
Hi Lionel and Christian, Below is robot report for chain->prev, which was added __rcu as you suggested. How to fix this line "tmp = cmpxchg(&chain->prev, prev, replacement); "? I checked kernel header file, seems it has no cmpxchg for rcu. Any suggestion to fix this robot report? Thanks, -Da

Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-20 Thread kbuild test robot
Hi Chunming, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.1-rc1 next-20190320] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu

[PATCH 1/9] dma-buf: add new dma_fence_chain container v6

2019-03-19 Thread Chunming Zhou
From: Christian König Lockless container implementation similar to a dma_fence_array, but with only two elements per node and automatic garbage collection. v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno, drop prev reference during garbage collection if it's no