Re: [PATCH 1/8] drm: Introduce an atomic_commit_setup function

2020-11-21 Thread Maxime Ripard
Hi Daniel, Thanks for your review On Fri, Nov 13, 2020 at 10:02:40PM +0100, Daniel Vetter wrote: > > +* is not used by the atomic helpers. > > +* > > +* This function is called at the end of > > +* drm_atomic_helper_setup_commit(), so once the commit has been > > +* properly s

Re: [PATCH 1/8] drm: Introduce an atomic_commit_setup function

2020-11-20 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 2:34 PM Maxime Ripard wrote: > > Hi Daniel, > > Thanks for your review > > On Fri, Nov 13, 2020 at 10:02:40PM +0100, Daniel Vetter wrote: > > > +* is not used by the atomic helpers. > > > +* > > > +* This function is called at the end of > > > +* drm_atomic_

Re: [PATCH 1/8] drm: Introduce an atomic_commit_setup function

2020-11-20 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 9:39 AM Thomas Zimmermann wrote: > > Hi > > Am 19.11.20 um 16:32 schrieb Daniel Vetter: > > On Thu, Nov 19, 2020 at 10:59:42AM +0100, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 13.11.20 um 16:29 schrieb Maxime Ripard: > >>> Private objects storing a state shared across a

Re: [PATCH 1/8] drm: Introduce an atomic_commit_setup function

2020-11-20 Thread Thomas Zimmermann
Hi Am 19.11.20 um 16:32 schrieb Daniel Vetter: On Thu, Nov 19, 2020 at 10:59:42AM +0100, Thomas Zimmermann wrote: Hi Am 13.11.20 um 16:29 schrieb Maxime Ripard: Private objects storing a state shared across all CRTCs need to be carefully handled to avoid a use-after-free issue. The proper wa

Re: [PATCH 1/8] drm: Introduce an atomic_commit_setup function

2020-11-19 Thread Daniel Vetter
On Thu, Nov 19, 2020 at 10:59:42AM +0100, Thomas Zimmermann wrote: > Hi > > Am 13.11.20 um 16:29 schrieb Maxime Ripard: > > Private objects storing a state shared across all CRTCs need to be > > carefully handled to avoid a use-after-free issue. > > > > The proper way to do this to track all the

Re: [PATCH 1/8] drm: Introduce an atomic_commit_setup function

2020-11-19 Thread Thomas Zimmermann
Hi Am 13.11.20 um 16:29 schrieb Maxime Ripard: Private objects storing a state shared across all CRTCs need to be carefully handled to avoid a use-after-free issue. The proper way to do this to track all the commits using that shared state and wait for the previous commits to be done before goi

[PATCH 1/8] drm: Introduce an atomic_commit_setup function

2020-11-15 Thread Maxime Ripard
Private objects storing a state shared across all CRTCs need to be carefully handled to avoid a use-after-free issue. The proper way to do this to track all the commits using that shared state and wait for the previous commits to be done before going on with the current one to avoid the reordering

Re: [PATCH 1/8] drm: Introduce an atomic_commit_setup function

2020-11-13 Thread Daniel Vetter
On Fri, Nov 13, 2020 at 04:29:49PM +0100, Maxime Ripard wrote: > Private objects storing a state shared across all CRTCs need to be > carefully handled to avoid a use-after-free issue. > > The proper way to do this to track all the commits using that shared > state and wait for the previous commit