Re: [PATCH 1/7] drm/syncobj: Remove unhelpful helper

2025-03-25 Thread Tvrtko Ursulin
On 24/03/2025 21:38, Maíra Canal wrote: Hi Tvrtko, Some nits inline, but feel free to ignore them if you don't think they are reasonable. Apart from that, Reviewed-by: Maíra Canal On 18/03/25 12:54, Tvrtko Ursulin wrote: Helper which fails to consolidate the code and instead just forks into

Re: [PATCH 1/7] drm/syncobj: Remove unhelpful helper

2025-03-24 Thread Maíra Canal
Hi Tvrtko, Some nits inline, but feel free to ignore them if you don't think they are reasonable. Apart from that, Reviewed-by: Maíra Canal On 18/03/25 12:54, Tvrtko Ursulin wrote: Helper which fails to consolidate the code and instead just forks into two copies of the code based on a boolean

[PATCH 1/7] drm/syncobj: Remove unhelpful helper

2025-03-18 Thread Tvrtko Ursulin
Helper which fails to consolidate the code and instead just forks into two copies of the code based on a boolean parameter is not very helpful or readable. Lets just remove it and proof in the pudding is the net smaller code. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_syncobj.c | 98 +

[PATCH 1/7] drm/syncobj: Remove unhelpful helper

2025-01-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Helper which fails to consolidate the code and instead just forks into two copies of the code based on a boolean parameter is not very helpful or readable. Lets just remove it and proof in the pudding is the net smaller code. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/d