Re: [PATCH 1/7] drm/hisilicon/hibmc: Fix preferred depth and bpp

2022-11-18 Thread Javier Martinez Canillas
On 11/18/22 14:18, Thomas Zimmermann wrote: [...] >> >> In the cover letter you said "color depth is the number of color and alpha >> bits >> that affect image composition" but it should be "only the number of color >> bits >> excluding the alpha bits" a better description right? > > I was loo

Re: [PATCH 1/7] drm/hisilicon/hibmc: Fix preferred depth and bpp

2022-11-18 Thread Thomas Zimmermann
Hi Javier Am 18.11.22 um 13:52 schrieb Javier Martinez Canillas: Hello Thomas, On 11/16/22 17:09, Thomas Zimmermann wrote: Set the preferred color depth to 24 bits and the fbdev bpp to 32 bits. This will signal XRGB as default format to clients. Signed-off-by: Thomas Zimmermann --- dri

Re: [PATCH 1/7] drm/hisilicon/hibmc: Fix preferred depth and bpp

2022-11-18 Thread Javier Martinez Canillas
Hello Thomas, On 11/16/22 17:09, Thomas Zimmermann wrote: > Set the preferred color depth to 24 bits and the fbdev bpp to 32 > bits. This will signal XRGB as default format to clients. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++-- > 1

[PATCH 1/7] drm/hisilicon/hibmc: Fix preferred depth and bpp

2022-11-16 Thread Thomas Zimmermann
Set the preferred color depth to 24 bits and the fbdev bpp to 32 bits. This will signal XRGB as default format to clients. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/