Re: [PATCH 1/6] drm: Inline AGP wrappers into their only callers

2021-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 10:56 AM Thomas Zimmermann wrote: > > Hi > > Am 12.01.21 um 09:59 schrieb Daniel Vetter: > > On Tue, Jan 12, 2021 at 09:10:30AM +0100, Thomas Zimmermann wrote: > >> The AGP wrapper functions serve no purpose. > >> > >> Signed-off-by: Thomas Zimmermann > > > > They do, with

Re: [PATCH 1/6] drm: Inline AGP wrappers into their only callers

2021-01-12 Thread Thomas Zimmermann
Hi Am 12.01.21 um 09:59 schrieb Daniel Vetter: On Tue, Jan 12, 2021 at 09:10:30AM +0100, Thomas Zimmermann wrote: The AGP wrapper functions serve no purpose. Signed-off-by: Thomas Zimmermann They do, without them we fail compiling (I think at least) when agp isn't I thought so. But the on

Re: [PATCH 1/6] drm: Inline AGP wrappers into their only callers

2021-01-12 Thread Daniel Vetter
On Tue, Jan 12, 2021 at 09:10:30AM +0100, Thomas Zimmermann wrote: > The AGP wrapper functions serve no purpose. > > Signed-off-by: Thomas Zimmermann They do, without them we fail compiling (I think at least) when agp isn't enabled. Did you check for that? I should all work if we have the dummy

[PATCH 1/6] drm: Inline AGP wrappers into their only callers

2021-01-12 Thread Thomas Zimmermann
The AGP wrapper functions serve no purpose. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_agpsupport.c | 12 ++-- drivers/gpu/drm/drm_memory.c | 18 -- include/drm/drm_agpsupport.h | 18 -- 3 files changed, 6 insertions(+), 42 deletions(