Re: [PATCH 1/6] drm: Fix drm_release() and device unplug

2019-02-07 Thread Sean Paul
On Sun, Feb 03, 2019 at 04:41:55PM +0100, Noralf Trønnes wrote: > If userspace has open fd(s) when drm_dev_unplug() is run, it will result > in drm_dev_unregister() being called twice. First in drm_dev_unplug() and > then later in drm_release() through the call to drm_put_dev(). > > Since userspac

Re: [PATCH 1/6] drm: Fix drm_release() and device unplug

2019-02-05 Thread Oleksandr Andrushchenko
On 2/3/19 5:41 PM, Noralf Trønnes wrote: > If userspace has open fd(s) when drm_dev_unplug() is run, it will result > in drm_dev_unregister() being called twice. First in drm_dev_unplug() and > then later in drm_release() through the call to drm_put_dev(). > > Since userspace already holds a ref on

[PATCH 1/6] drm: Fix drm_release() and device unplug

2019-02-03 Thread Noralf Trønnes
If userspace has open fd(s) when drm_dev_unplug() is run, it will result in drm_dev_unregister() being called twice. First in drm_dev_unplug() and then later in drm_release() through the call to drm_put_dev(). Since userspace already holds a ref on drm_device through the drm_minor, it's not necess