Re: [PATCH 1/6] drm/fb-helper: Avoid NULL ptr dereference in fb_set_suspend()

2017-09-02 Thread Noralf Trønnes
Den 31.08.2017 11.30, skrev Laurent Pinchart: Hello, On Tuesday, 29 August 2017 00:34:57 EEST Daniel Vetter wrote: On Mon, Aug 28, 2017 at 07:17:43PM +0200, Noralf Trønnes wrote: drm_fb_helper_resume_worker() uses fb_helper->fbdev to call fb_set_suspend() which dereferences the pointer. Move

Re: [PATCH 1/6] drm/fb-helper: Avoid NULL ptr dereference in fb_set_suspend()

2017-08-31 Thread Laurent Pinchart
Hello, On Tuesday, 29 August 2017 00:34:57 EEST Daniel Vetter wrote: > On Mon, Aug 28, 2017 at 07:17:43PM +0200, Noralf Trønnes wrote: > > drm_fb_helper_resume_worker() uses fb_helper->fbdev to call > > fb_set_suspend() which dereferences the pointer. > > Move sync-canceling of the resume worker i

Re: [PATCH 1/6] drm/fb-helper: Avoid NULL ptr dereference in fb_set_suspend()

2017-08-28 Thread Daniel Vetter
On Mon, Aug 28, 2017 at 07:17:43PM +0200, Noralf Trønnes wrote: > drm_fb_helper_resume_worker() uses fb_helper->fbdev to call > fb_set_suspend() which dereferences the pointer. > Move sync-canceling of the resume worker in drm_fb_helper_fini() before > setting fb_helper->fbdev to NULL. > > Signed-

[PATCH 1/6] drm/fb-helper: Avoid NULL ptr dereference in fb_set_suspend()

2017-08-28 Thread Noralf Trønnes
drm_fb_helper_resume_worker() uses fb_helper->fbdev to call fb_set_suspend() which dereferences the pointer. Move sync-canceling of the resume worker in drm_fb_helper_fini() before setting fb_helper->fbdev to NULL. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 3 ++- 1 file