Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-19 Thread Stefan Agner
On 14.09.2018 02:49, Laurent Pinchart wrote: > Hi Stefan, > > On Thursday, 6 September 2018 23:25:56 EEST Stefan Agner wrote: >> On 06.09.2018 04:07, Linus Walleij wrote: >> > On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote: >> >> On 05.09.2018 00:44, Laurent Pinchart wrote: >> >> >> >> Good po

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-14 Thread Laurent Pinchart
On Friday, 14 September 2018 12:49:40 EEST Laurent Pinchart wrote: > Hi Stefan, > > On Thursday, 6 September 2018 23:25:56 EEST Stefan Agner wrote: > > On 06.09.2018 04:07, Linus Walleij wrote: > > > On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote: > > >> On 05.09.2018 00:44, Laurent Pinchart w

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-14 Thread Laurent Pinchart
Hi Stefan, On Friday, 7 September 2018 21:25:40 EEST Stefan Agner wrote: > On 07.09.2018 00:10, Linus Walleij wrote: > > On Thu, Sep 6, 2018 at 10:25 PM Stefan Agner wrote: > >> Ok, I read a bit up on the history of bridge timing, especially: > >> https://www.spinics.net/lists/dri-devel/msg155618

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-14 Thread Laurent Pinchart
Hi Stefan, On Thursday, 6 September 2018 23:25:56 EEST Stefan Agner wrote: > On 06.09.2018 04:07, Linus Walleij wrote: > > On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote: > >> On 05.09.2018 00:44, Laurent Pinchart wrote: > >> > >> Good point! I actually really don't like that we use the same

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-07 Thread Stefan Agner
On 07.09.2018 00:10, Linus Walleij wrote: > On Thu, Sep 6, 2018 at 10:25 PM Stefan Agner wrote: > >> Ok, I read a bit up on the history of bridge timing, especially: >> https://www.spinics.net/lists/dri-devel/msg155618.html >> >> IMHO, this got overengineered. For displays we do not need all that

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-07 Thread Linus Walleij
On Thu, Sep 6, 2018 at 10:25 PM Stefan Agner wrote: > Ok, I read a bit up on the history of bridge timing, especially: > https://www.spinics.net/lists/dri-devel/msg155618.html > > IMHO, this got overengineered. For displays we do not need all that > setup/sample delay timing information, and much

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-06 Thread Stefan Agner
On 06.09.2018 04:07, Linus Walleij wrote: > On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote: >> On 05.09.2018 00:44, Laurent Pinchart wrote: > >> Good point! I actually really don't like that we use the same flags here >> but from a different perspective. Especially since the flags defines >> d

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-06 Thread Stefan Agner
On 06.09.2018 09:54, Laurent Pinchart wrote: > Hi Stefan, > > On Thursday, 6 September 2018 19:48:51 EEST Stefan Agner wrote: >> On 06.09.2018 05:25, Laurent Pinchart wrote: >> > On Thursday, 6 September 2018 14:07:41 EEST Linus Walleij wrote: >> >> On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wro

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-06 Thread Laurent Pinchart
Hi Stefan, On Thursday, 6 September 2018 19:48:51 EEST Stefan Agner wrote: > On 06.09.2018 05:25, Laurent Pinchart wrote: > > On Thursday, 6 September 2018 14:07:41 EEST Linus Walleij wrote: > >> On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote: > >> > On 05.09.2018 00:44, Laurent Pinchart wrote

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-06 Thread Stefan Agner
On 06.09.2018 05:25, Laurent Pinchart wrote: > Hi Linus, > > On Thursday, 6 September 2018 14:07:41 EEST Linus Walleij wrote: >> On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote: >> > On 05.09.2018 00:44, Laurent Pinchart wrote: >> > >> > Good point! I actually really don't like that we use the

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-06 Thread Laurent Pinchart
Hi Linus, On Thursday, 6 September 2018 14:07:41 EEST Linus Walleij wrote: > On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote: > > On 05.09.2018 00:44, Laurent Pinchart wrote: > > > > Good point! I actually really don't like that we use the same flags here > > but from a different perspective.

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-06 Thread Linus Walleij
On Wed, Sep 5, 2018 at 8:32 PM Stefan Agner wrote: > On 05.09.2018 00:44, Laurent Pinchart wrote: > Good point! I actually really don't like that we use the same flags here > but from a different perspective. Especially since the flags defines > document things differently: > > /* drive data on p

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-05 Thread Stefan Agner
On 05.09.2018 00:44, Laurent Pinchart wrote: > Hi Stefan, > > On Wednesday, 5 September 2018 10:06:28 EEST Laurent Pinchart wrote: >> On Wednesday, 5 September 2018 08:21:08 EEST Stefan Agner wrote: >> > The DRM bus flags convey additional information on pixel data on >> > the bus. All current ava

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-05 Thread Stefan Agner
On 05.09.2018 11:00, Stefan Agner wrote: > The DRM bus flags convey additional information on pixel data on > the bus. All current available bus flags might be of interest for > a bridge. Remove the sampling_edge field and use bus_flags. > > In the case at hand a dumb VGA bridge needs a specific d

[PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-05 Thread Stefan Agner
The DRM bus flags convey additional information on pixel data on the bus. All current available bus flags might be of interest for a bridge. Remove the sampling_edge field and use bus_flags. In the case at hand a dumb VGA bridge needs a specific data enable polarity (DRM_BUS_FLAG_DE_LOW). Signed-

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-05 Thread Laurent Pinchart
Hi Stefan, On Wednesday, 5 September 2018 10:06:28 EEST Laurent Pinchart wrote: > On Wednesday, 5 September 2018 08:21:08 EEST Stefan Agner wrote: > > The DRM bus flags convey additional information on pixel data on > > the bus. All current available bus flags might be of interest for > > a bridge

Re: [PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-05 Thread Laurent Pinchart
Hi Stefan, Thank you for the patch. On Wednesday, 5 September 2018 08:21:08 EEST Stefan Agner wrote: > The DRM bus flags convey additional information on pixel data on > the bus. All current available bus flags might be of interest for > a bridge. Remove the sampling_edge field and use bus_flags.

[PATCH 1/6] drm/bridge: use bus flags in bridge timings

2018-09-04 Thread Stefan Agner
The DRM bus flags convey additional information on pixel data on the bus. All current available bus flags might be of interest for a bridge. Remove the sampling_edge field and use bus_flags. In the case at hand a dumb VGA bridge needs a specific data enable polarity (DRM_BUS_FLAG_DE_LOW). Signed-