Re: [PATCH 1/5] drm/nouveau: Check backlight IDs are >= 0, not > 0

2018-08-23 Thread Lyude Paul
On Thu, 2018-08-23 at 14:00 +0200, Karol Herbst wrote: > Patches 1-5 are Reviewed-by: Karol Herbst > > I think it might be worth to test those patches on a system without > any backlight devices just to verify we don't break things, but the > code looked good already, so maybe we don't really nee

Re: [PATCH 1/5] drm/nouveau: Check backlight IDs are >= 0, not > 0

2018-08-23 Thread Karol Herbst
Patches 1-5 are Reviewed-by: Karol Herbst I think it might be worth to test those patches on a system without any backlight devices just to verify we don't break things, but the code looked good already, so maybe we don't really need to test. On Thu, Aug 23, 2018 at 3:21 AM, Lyude Paul wrote: >

[PATCH 1/5] drm/nouveau: Check backlight IDs are >= 0, not > 0

2018-08-22 Thread Lyude Paul
Remember, ida IDs start at 0, not 1! Signed-off-by: Lyude Paul Cc: sta...@vger.kernel.org Cc: Jeffery Miller Cc: Karol Herbst --- drivers/gpu/drm/nouveau/nouveau_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/d