Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members. (v3)

2017-03-20 Thread Daniel Vetter
On Mon, Mar 20, 2017 at 08:16:36AM +, Chris Wilson wrote: > On Mon, Mar 20, 2017 at 05:03:04PM +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > This patch allows the underlying fence in a sync_file to be changed > > or set to NULL. This isn't currently required but for Vulkan > > semap

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members. (v3)

2017-03-20 Thread Chris Wilson
On Mon, Mar 20, 2017 at 05:03:04PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This patch allows the underlying fence in a sync_file to be changed > or set to NULL. This isn't currently required but for Vulkan > semaphores we need to be able to swap and reset the fence. > > In order to fac

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members. (v3)

2017-03-20 Thread Chris Wilson
On Mon, Mar 20, 2017 at 05:03:04PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This patch allows the underlying fence in a sync_file to be changed > or set to NULL. This isn't currently required but for Vulkan > semaphores we need to be able to swap and reset the fence. > > In order to fac

[PATCH 1/4] sync_file: add a mutex to protect fence and callback members. (v3)

2017-03-20 Thread Dave Airlie
From: Dave Airlie This patch allows the underlying fence in a sync_file to be changed or set to NULL. This isn't currently required but for Vulkan semaphores we need to be able to swap and reset the fence. In order to faciliate this, it uses rcu to protect the fence, along with a new mutex. The

[PATCH 1/4] sync_file: add a mutex to protect fence and callback members. (v22)

2017-03-14 Thread Dave Airlie
From: Dave Airlie This isn't needed currently, but to reuse sync file for Vulkan permanent shared semaphore semantics, we need to be able to swap the fence backing a sync file. This patch adds a mutex to the sync file and uses to protect accesses to the fence and cb members. v1.1: fix the lockin

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members.

2017-03-14 Thread Dave Airlie
On 15 March 2017 at 10:47, Dave Airlie wrote: > On 14 March 2017 at 19:30, Christian König wrote: >> Am 14.03.2017 um 10:29 schrieb Chris Wilson: >>> >>> On Tue, Mar 14, 2017 at 10:13:37AM +0100, Christian König wrote: Am 14.03.2017 um 09:45 schrieb Daniel Vetter: > > On Tue, Ma

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members.

2017-03-14 Thread Dave Airlie
On 14 March 2017 at 19:30, Christian König wrote: > Am 14.03.2017 um 10:29 schrieb Chris Wilson: >> >> On Tue, Mar 14, 2017 at 10:13:37AM +0100, Christian König wrote: >>> >>> Am 14.03.2017 um 09:45 schrieb Daniel Vetter: On Tue, Mar 14, 2017 at 10:50:51AM +1000, Dave Airlie wrote: >

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members. (fwd)

2017-03-14 Thread Julia Lawall
Perhaps the mutex on line 410 needs to be considered on line 423. julia -- Forwarded message -- Hi Dave, [auto build test WARNING on drm/drm-next] [also build test WARNING on v4.11-rc2 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members.

2017-03-14 Thread Christian König
Am 14.03.2017 um 10:29 schrieb Chris Wilson: On Tue, Mar 14, 2017 at 10:13:37AM +0100, Christian König wrote: Am 14.03.2017 um 09:45 schrieb Daniel Vetter: On Tue, Mar 14, 2017 at 10:50:51AM +1000, Dave Airlie wrote: From: Dave Airlie This isn't needed currently, but to reuse sync file for V

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members.

2017-03-14 Thread Chris Wilson
On Tue, Mar 14, 2017 at 10:13:37AM +0100, Christian König wrote: > Am 14.03.2017 um 09:45 schrieb Daniel Vetter: > >On Tue, Mar 14, 2017 at 10:50:51AM +1000, Dave Airlie wrote: > >>From: Dave Airlie > >> > >>This isn't needed currently, but to reuse sync file for Vulkan > >>permanent shared semaph

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members.

2017-03-14 Thread Christian König
Am 14.03.2017 um 09:45 schrieb Daniel Vetter: On Tue, Mar 14, 2017 at 10:50:51AM +1000, Dave Airlie wrote: From: Dave Airlie This isn't needed currently, but to reuse sync file for Vulkan permanent shared semaphore semantics, we need to be able to swap the fence backing a sync file. This patch

Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members.

2017-03-14 Thread Daniel Vetter
On Tue, Mar 14, 2017 at 10:50:51AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This isn't needed currently, but to reuse sync file for Vulkan > permanent shared semaphore semantics, we need to be able to swap > the fence backing a sync file. This patch adds a mutex to the > sync file and us

[PATCH 1/4] sync_file: add a mutex to protect fence and callback members.

2017-03-13 Thread Dave Airlie
From: Dave Airlie This isn't needed currently, but to reuse sync file for Vulkan permanent shared semaphore semantics, we need to be able to swap the fence backing a sync file. This patch adds a mutex to the sync file and uses to protect accesses to the fence and cb members. Signed-off-by: Dave