Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Mikko Perttunen
On 08/19/2017 01:36 AM, Dmitry Osipenko wrote: On 18.08.2017 19:15, Mikko Perttunen wrote: Since Tegra186 the Host1x hardware allows syncpoints to be assigned to specific channels, preventing any other channels from incrementing them. Enable this feature where available and assign syncpoints

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 19.08.2017 13:35, Mikko Perttunen wrote: > On 08/19/2017 01:09 PM, Dmitry Osipenko wrote: >> On 19.08.2017 11:10, Mikko Perttunen wrote: >> [snip] > +host1x_hw_syncpt_set_protection(host, true); Is it really okay to force the protection? Maybe protection should be enabled

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job. Syncp

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job. Syncp

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 19.08.2017 14:32, Mikko Perttunen wrote: > > > On 08/19/2017 02:11 PM, Dmitry Osipenko wrote: >> On 19.08.2017 13:35, Mikko Perttunen wrote: >>> On 08/19/2017 01:09 PM, Dmitry Osipenko wrote: On 19.08.2017 11:10, Mikko Perttunen wrote: [snip] >>> +host1x_hw_syncpt_set_protect

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job. Syncp

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Mikko Perttunen
On 08/19/2017 01:09 PM, Dmitry Osipenko wrote: On 19.08.2017 11:10, Mikko Perttunen wrote: [snip] +host1x_hw_syncpt_set_protection(host, true); Is it really okay to force the protection? Maybe protection should be enabled with a respect to CONFIG_TEGRA_HOST1X_FIREWALL? In that case we woul

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Mikko Perttunen
On 08/19/2017 02:11 PM, Dmitry Osipenko wrote: On 19.08.2017 13:35, Mikko Perttunen wrote: On 08/19/2017 01:09 PM, Dmitry Osipenko wrote: On 19.08.2017 11:10, Mikko Perttunen wrote: [snip] +host1x_hw_syncpt_set_protection(host, true); Is it really okay to force the protection? Maybe pr

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job. Syncp

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job. Syncp

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 19.08.2017 11:10, Mikko Perttunen wrote: [snip] >>> +host1x_hw_syncpt_set_protection(host, true); >> >> Is it really okay to force the protection? Maybe protection should be enabled >> with a respect to CONFIG_TEGRA_HOST1X_FIREWALL? In that case we would have to >> avoid software jobs valida

[PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-18 Thread Mikko Perttunen
Since Tegra186 the Host1x hardware allows syncpoints to be assigned to specific channels, preventing any other channels from incrementing them. Enable this feature where available and assign syncpoints to channels when submitting a job. Syncpoints are currently never unassigned from channels since