[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-18 Thread Emil Velikov
On 4 August 2016 at 17:09, Daniel Vetter wrote: > On Thu, Aug 04, 2016 at 03:31:45PM +0100, Emil Velikov wrote: >> On 4 August 2016 at 14:15, Sharma, Shashank >> wrote: >> > On 8/4/2016 5:04 PM, Emil Velikov wrote: >> >> >> >> On 4 August 2016 at 11:16, Sharma, Shashank >> >> wrote: >> >>> >> >

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-09 Thread Daniel Vetter
On Tue, Aug 9, 2016 at 3:12 PM, Jose Abreu wrote: > Will you send a new version of these patches? I have a patch > ready that adds the new HDMI 2.0 modes to the CEA modes list in > DRM but these modes require the addition of the new picture > aspect ratio flags (64:27, 256:135). I can either wait

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-09 Thread Jose Abreu
Hi Sharma, On 05-08-2016 04:37, Sharma, Shashank wrote: > Regards > > Shashank > > > On 8/4/2016 9:39 PM, Daniel Vetter wrote: >> On Thu, Aug 04, 2016 at 03:31:45PM +0100, Emil Velikov wrote: >>> On 4 August 2016 at 14:15, Sharma, Shashank >>> wrote: On 8/4/2016 5:04 PM, Emil Velikov wrote:

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-09 Thread Sharma, Shashank
; Vetter, Daniel ; intel-gfx at lists.freedesktop.org; ML dri-devel Subject: Re: [Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags On Tue, Aug 9, 2016 at 3:12 PM, Jose Abreu wrote: > Will you send a new version of these patches? I have a patch ready > that adds the new HDMI 2.0

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-05 Thread Sharma, Shashank
Regards Shashank On 8/4/2016 9:39 PM, Daniel Vetter wrote: > On Thu, Aug 04, 2016 at 03:31:45PM +0100, Emil Velikov wrote: >> On 4 August 2016 at 14:15, Sharma, Shashank >> wrote: >>> On 8/4/2016 5:04 PM, Emil Velikov wrote: On 4 August 2016 at 11:16, Sharma, Shashank wrote: > H

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Sharma, Shashank
Regards Shashank On 8/4/2016 5:04 PM, Emil Velikov wrote: > On 4 August 2016 at 11:16, Sharma, Shashank > wrote: >> Hello Emil, >> >> Thanks for your time. >> >> I have got mixed opinion on this. >> >> IMHO we should expose them to userspace too, as UI agents like Hardware >> composer/X/Waylan

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Sharma, Shashank
Thanks Daniel. My comments, inline. Regards Shashank On 8/4/2016 4:06 PM, Daniel Vetter wrote: > On Thu, Aug 04, 2016 at 03:46:09PM +0530, Sharma, Shashank wrote: >> Hello Emil, >> >> Thanks for your time. >> >> I have got mixed opinion on this. >> >> IMHO we should expose them to userspace too,

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Daniel Vetter
On Thu, Aug 04, 2016 at 03:31:45PM +0100, Emil Velikov wrote: > On 4 August 2016 at 14:15, Sharma, Shashank > wrote: > > On 8/4/2016 5:04 PM, Emil Velikov wrote: > >> > >> On 4 August 2016 at 11:16, Sharma, Shashank > >> wrote: > >>> > >>> Hello Emil, > >>> > >>> Thanks for your time. > >>> > >>

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Daniel Vetter
On Thu, Aug 04, 2016 at 06:35:52PM +0530, Sharma, Shashank wrote: > Thanks Daniel. > > My comments, inline. > > Regards > Shashank > On 8/4/2016 4:06 PM, Daniel Vetter wrote: > > On Thu, Aug 04, 2016 at 03:46:09PM +0530, Sharma, Shashank wrote: > > > Hello Emil, > > > > > > Thanks for your time.

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Sharma, Shashank
Hello Emil, Thanks for your time. I have got mixed opinion on this. IMHO we should expose them to userspace too, as UI agents like Hardware composer/X/Wayland must know what does these flags means, so that they can display them on the end user screen (like settings menu) But few people even

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Emil Velikov
On 4 August 2016 at 14:15, Sharma, Shashank wrote: > On 8/4/2016 5:04 PM, Emil Velikov wrote: >> >> On 4 August 2016 at 11:16, Sharma, Shashank >> wrote: >>> >>> Hello Emil, >>> >>> Thanks for your time. >>> >>> I have got mixed opinion on this. >>> >>> IMHO we should expose them to userspace to

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Sharma, Shashank
Thanks for the review, Sean. My comments, inline. Regards Shashank On 8/3/2016 11:10 PM, Sean Paul wrote: > On Wed, Aug 3, 2016 at 6:56 AM, Shashank Sharma > wrote: >> This patch adds drm flag bits for aspect ratio information >> >> Currently drm flag bits don't have field for mode's picture >>

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Daniel Vetter
On Thu, Aug 04, 2016 at 03:46:09PM +0530, Sharma, Shashank wrote: > Hello Emil, > > Thanks for your time. > > I have got mixed opinion on this. > > IMHO we should expose them to userspace too, as UI agents like Hardware > composer/X/Wayland must know what does these > > flags means, so that the

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Emil Velikov
On 4 August 2016 at 11:16, Sharma, Shashank wrote: > Hello Emil, > > Thanks for your time. > > I have got mixed opinion on this. > > IMHO we should expose them to userspace too, as UI agents like Hardware > composer/X/Wayland must know what does these > > flags means, so that they can display the

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-04 Thread Emil Velikov
On 3 August 2016 at 11:56, Shashank Sharma wrote: > --- a/include/uapi/drm/drm_mode.h > +++ b/include/uapi/drm/drm_mode.h > + > +/* Aspect ratio flag bitmask (4 bits 22:19) */ > +#define DRM_MODE_FLAG_PARMASK (0x0F<<19) > +#define DRM_MODE_FLAG_PARNONE \ > +

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-03 Thread Shashank Sharma
This patch adds drm flag bits for aspect ratio information Currently drm flag bits don't have field for mode's picture aspect ratio. This field will help the driver to pick mode with right aspect ratio, and help in setting right VIC field in avi infoframes. Signed-off-by: Shashank Sharma --- in

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-03 Thread Sean Paul
On Wed, Aug 3, 2016 at 6:56 AM, Shashank Sharma wrote: > This patch adds drm flag bits for aspect ratio information > > Currently drm flag bits don't have field for mode's picture > aspect ratio. This field will help the driver to pick mode with > right aspect ratio, and help in setting right VIC