Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-03-06 Thread Harry Wentland
On 2018-03-06 02:51 AM, Daniel Vetter wrote: > On Fri, Feb 23, 2018 at 11:26:41AM -0500, Harry Wentland wrote: >> On 2018-02-22 04:42 PM, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> The documentation for the ctm matrix suggests a two's complement >>> format, but at least the i915 implemen

Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-03-05 Thread Daniel Vetter
On Fri, Feb 23, 2018 at 11:26:41AM -0500, Harry Wentland wrote: > On 2018-02-22 04:42 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The documentation for the ctm matrix suggests a two's complement > > format, but at least the i915 implementation is using sign-magnitude > > instead. And

Re: [Intel-gfx] [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-28 Thread Ville Syrjälä
On Fri, Feb 23, 2018 at 04:04:10PM +0200, Ville Syrjälä wrote: > On Fri, Feb 23, 2018 at 01:52:22PM +, Brian Starkey wrote: > > Hi Ville, > > > > On Thu, Feb 22, 2018 at 11:42:29PM +0200, Ville Syrjala wrote: > > >From: Ville Syrjälä > > > > > >The documentation for the ctm matrix suggests a

Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-23 Thread Ville Syrjälä
On Fri, Feb 23, 2018 at 11:26:41AM -0500, Harry Wentland wrote: > On 2018-02-22 04:42 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The documentation for the ctm matrix suggests a two's complement > > format, but at least the i915 implementation is using sign-magnitude > > instead. And

Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-23 Thread Harry Wentland
On 2018-02-22 04:42 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > The documentation for the ctm matrix suggests a two's complement > format, but at least the i915 implementation is using sign-magnitude > instead. And looks like malidp is doing the same. Change the docs > to match the current

Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-23 Thread Ville Syrjälä
On Fri, Feb 23, 2018 at 01:52:22PM +, Brian Starkey wrote: > Hi Ville, > > On Thu, Feb 22, 2018 at 11:42:29PM +0200, Ville Syrjala wrote: > >From: Ville Syrjälä > > > >The documentation for the ctm matrix suggests a two's complement > >format, but at least the i915 implementation is using sig

Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-23 Thread Brian Starkey
Hi Ville, On Thu, Feb 22, 2018 at 11:42:29PM +0200, Ville Syrjala wrote: From: Ville Syrjälä The documentation for the ctm matrix suggests a two's complement format, but at least the i915 implementation is using sign-magnitude instead. And looks like malidp is doing the same. Change the docs t

RE: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-23 Thread Shankar, Uma
iners >; Lin, Johnson ; Shankar, Uma >; Sharma, Shashank >Subject: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude >representation > >From: Ville Syrjälä > >The documentation for the ctm matrix suggests a two's complement format, but >at least the i915 impl

[PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-22 Thread Ville Syrjala
From: Ville Syrjälä The documentation for the ctm matrix suggests a two's complement format, but at least the i915 implementation is using sign-magnitude instead. And looks like malidp is doing the same. Change the docs to match the current implementation, and change the type from __s64 to __u64